Made it possible to switch UI to english in development #384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
damisul
commented
Jun 14, 2024
| @@ -0,0 +1 @@ | |||
| BY_LANGUAGE=he | |||
There was a problem hiding this comment.
provided as an example for dotenv config. To override it locally create a new file .env.development.local (should not be committed to git)
| @@ -68,16 +68,11 @@ | |||
| # Enable threaded mode | |||
| # config.threadsafe! | |||
|
|
|||
| # Enable locale fallbacks for I18n (makes lookups for any locale fall back to | |||
| # the I18n.default_locale when a translation can not be found) | |||
| config.i18n.fallbacks = true | |||
There was a problem hiding this comment.
already specified in application.rb
| # Send deprecation notices to registered listeners | ||
| config.active_support.deprecation = :notify | ||
|
|
||
| config.action_mailer.delivery_method = :sendmail # let's start sending mail :) | ||
| config.eager_load = true | ||
| config.i18n.available_locales = :he |
There was a problem hiding this comment.
already specified in application.rb
| @@ -102,10 +97,6 @@ | |||
| # Set this to true and configure the email server for immediate delivery to raise delivery errors. | |||
| # config.action_mailer.raise_delivery_errors = false | |||
|
|
|||
| # Enable locale fallbacks for I18n (makes lookups for any locale fall back to | |||
| # the I18n.default_locale when a translation cannot be found). | |||
| config.i18n.fallbacks = true | |||
There was a problem hiding this comment.
was a duplicate line and now specified in application.rb
…sing BY_LANGUAGE env variable. Added dotenv gem to easily manage env variables in development
damisul
force-pushed
the
english_ui_in_development
branch
from
f45ee51 to
0a7163d
Compare
damisul
commented
Jun 14, 2024
| @@ -54,7 +55,6 @@ | |||
| #config.assets.debug = true | |||
| config.eager_load = false | |||
| # config.public_file_server.enabled = true # Rails 5.x? | |||
| config.i18n.available_locales = :he | |||
There was a problem hiding this comment.
defined in application.rb
damisul
commented
Jun 14, 2024
| @@ -1,4 +1,5 @@ | |||
| en: | |||
| edit_metadata: Edit metadata | |||
abartov
approved these changes
Jun 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If BY_LANGUAGE env variable is provided it will try to use given locale as default.
For now only en or he locale is accepted (and only in dev environment)
I've added dotenv gem to simply manage env variables in development and test. I plan to use it also in #166
You can create
.env.development.localfile and override BY_LANGUAGE value there instead of overwriting.env.development