Catch all collection #403
Merged
Catch all collection #403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
damisul
commented
Jul 22, 2024
|
|
||
| != ' ' | ||
| %span.static-btn | ||
| %b= link_to 'Refresh uncollected works', |
There was a problem hiding this comment.
Temporary link to call service to refresh uncollected works collection. I did not bothered about I18n, as it is a temporary solution.
| @@ -37,5 +37,5 @@ | |||
| - else | |||
| .headline-3-v02 | |||
| = t(:text) | |||
| : | |||
| \: | |||
There was a problem hiding this comment.
Without escaping this line caused error.
damisul
force-pushed
the
catch_all_collection
branch
from
926b8e3 to
9f0f076
Compare
damisul
force-pushed
the
catch_all_collection
branch
from
9f0f076 to
3df1a8f
Compare
damisul
force-pushed
the
catch_all_collection
branch
from
3df1a8f to
324e7fc
Compare
abartov
approved these changes
Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of prerequisites of creating root collection functionality is to implement 'catch all' colleciton for all uncollected works per authority.
This PR adds new collection type 'uncollected', and adds authorities.uncollected_works_collection_id column to link those collections with authorities. So each authority can have own collection.
There is a new service RefreshUncollectedWorksCollection, used to create or update uncollected collection per authority.
For test purpose I've added a new link 'Refresh uncollected works collection' to Author's TOC page, which calls this service. Later we can remove it and made service to be run automatically on certain events. This service does two things:
NOTE: I've created new AuthoritiesController in admin namespace for this purpose. I propose to move all non-public actions related to authorities theres instead of AuthorsController (in future we can make AuthorsController to be responsible for public functionality, and admin/authorities controller to be responsible for editor functions).