Rspec fix #442
Merged
Rspec fix #442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e impressions_count, so in this case we need to additionally sort records by id, to match TextAPI behaviour
damisul
commented
Nov 26, 2024
| @@ -1,7 +1,8 @@ | |||
| FROM ruby:3.2.1-buster | |||
| FROM ruby:3.3.5-bullseye | |||
There was a problem hiding this comment.
bumped version of docker image to match updated ruby version
abartov
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed error in specs.
Problem occured when there where two manifestations with same impressions_count.
In this case TextAPI uses additional sorting by id, but spec code ignored it. Added missing sorting by id