Batch delete of collection_items #454
Open
+84
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
damisul
commented
Dec 19, 2024
| @@ -0,0 +1,8 @@ | |||
| $selected-background: navy; | |||
There was a problem hiding this comment.
styles used to highlight selected items in list.
I've used SCSS, so you can change those two constants only and they'll be used in underlying styles
| @@ -1,3 +0,0 @@ | |||
| ele = $('div[id*="<%= 'collitem_'+@deleted_id.to_s %>"]'); | |||
There was a problem hiding this comment.
I've used this code in $.ajax success callback
| @@ -26,7 +26,6 @@ | |||
| %br | |||
| .editable{ id: "#{nonce}_editable_#{ci.id}" } | |||
| != MultiMarkdown.new(ci.markdown).to_html | |||
| = link_to t(:delete), collection_item_path(ci.id), method: :delete, remote: true, data: { confirm: t(:confirm_delete_collection_item) }, class: 'collection-btn', style: 'float: left;top:-40px;left:5px;position:relative;z-index:5;' | |||
There was a problem hiding this comment.
those 'delete' links are removed as now we have batch delete button
| @@ -1483,6 +1483,11 @@ he: | |||
| permission_for_all: על אף שהיצירה עדיין מוגנת בזכויות יוצרים, פרויקט בן־יהודה קיבל *רשות מפורשת לפרסם* את היצירה במאגר היצירה של פרויקט בן־יהודה, לשימוש הקהל הרחב לקריאה ומחקר. שימושים אחרים (כגון המחזה, הלחנה, או ביצוע מסחרי) עדיין *טעונים אישור מפורש* מאת בעלי הזכויות. | |||
| permission_for_selected: על אף שהיצירה עדיין מוגנת בזכויות יוצרים, פרויקט בן־יהודה קיבל *רשות מפורשת לפרסם* את היצירה במאגר היצירה של פרויקט בן־יהודה, לשימוש הקהל הרחב לקריאה ומחקר. שימושים אחרים (כגון המחזה, הלחנה, או ביצוע מסחרי) עדיין *טעונים אישור מפורש* מאת בעלי הזכויות. | |||
| unknown: "על אף כל המאמצים, לא ניתן לקבוע מה מצב זכויות היוצרים, בדרך כלל בשל מידע חסר לגבי זהות או מועד פטירת המחבר[ים] או המתרגם[ים]." | |||
| manage_collection: | |||
There was a problem hiding this comment.
As usual some strings awaits translation
damisul
commented
Dec 19, 2024
| url: '/collection_items/' + id, | ||
| type: 'DELETE', | ||
| success: function() { | ||
| const ele = $('div[id*="collitem_' + id + '"]'); |
There was a problem hiding this comment.
Here is the code from removed destroy.js.erb.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added ability to select multiple items on collections/manage page by clicking on items (hold Ctrl to select multiple items).
If one or more items are selected page will show a button to remove selected items:
I've removed 'delete' link we had previously on every item in list as it become obsolete now.