Sub-collection addition failed on collection/manage page

[damisul]

It was impossible to add a new existing sub-collection (using autocomplete) on collection/manage page as we missed 'Collection' item_type value in drop-down.

[abartov]

Just FYI: I merged this by mistake. The behavior had in fact been correct: it is impossible to just add a Collection -- the method already includes all Collection types (volume, series, etc.) plus the leaf types. The user should pick a specific Collection type (e.g. 'volume') to add. I have now removed the line you added.

[damisul]

Just FYI: I merged this by mistake. The behavior had in fact been correct: it is impossible to just add a Collection -- the method already includes all Collection types (volume, series, etc.) plus the leaf types. The user should pick a specific Collection type (e.g. 'volume') to add. I have now removed the line you added.

Hi @abartov
Maybe I've fixed it wrongly, but I still believe there is something to be fixed.

The problem I've tried to fix was not creation of new Collection as sub-collection, but adding some already existing Collection as a sub-collection. There is an autocomplete field to select collection, it allows to select existing works, but if we try to add it, an error occurs (it does not displays, but is visible in logs):

And if we'll check this line:

bybeconv/app/views/shared/_manage_collection.html.haml

Line 105 in c508ec4

var item_id = (item_type == 'Manifestation') ? $(this).parent().parent().find('#insert_mid').val() : (item_type == 'Collection') ? $(this).parent().parent().find('#insert_cid').val() : '';

We see that item_type == 'Collection' is also expected.

So I've asssumed that intended logic was:

• if we want to create new sub-collection and add it then we should select some collection_item type from drop-down (e.g. volume or periodical)
• but if we want to find and add existing collection, then item_type should be set to 'Collection' and we miss this value in a drop-down. So I've added it.

Without this entry we cannot add existing collection as sub-collection.

Sidethinking: I believe this UI for adding new Collection_item using single form is a bit contr-intuitive.
The problem with UI is that we need to select specific values in a drop-down for each possible case. I'd suggested to use several smaller forms instead:

• to add existing manifestation (using autocomplete)
• to add existing collection (using autocomplete)
• to create new placeholder
• to create new collection (should only allows to select valid collection_type values from a drop-down without 'Collection' and 'Manifestation' entries)

So we need to at least fix this error then.