Refactor

abdellani · Sep 26, 2023 · 91b251a · 91b251a
1 parent 50eb8f3
commit 91b251a
Showing 1 changed file with 6 additions and 8 deletions.
diff --git a/app/models/product_import/entry_validator.rb b/app/models/product_import/entry_validator.rb
@@ -67,16 +67,14 @@ def enterprise_field
     end
 
     def mark_as_new_variant(entry, product_id)
+      variant_attributes = entry.assignable_attributes.except(
+        'id', 'product_id', 'on_hand', 'on_demand', 'variant_unit', 'variant_unit_name',
+        'variant_unit_scale', 'primary_taxon_id'
+      )
       # Variant needs a product. Product needs to be assigned first in order for
       # delegate to work. name= will fail otherwise.
-      new_variant = Spree::Variant.new(
-        { product_id: }
-        .merge(
-          entry.assignable_attributes.except('id', 'product_id', 'on_hand', 'on_demand',
-                                             'variant_unit', 'variant_unit_name',
-                                             'variant_unit_scale', 'primary_taxon_id')
-        )
-      )
+      new_variant = Spree::Variant.new(product_id:, **variant_attributes)
+
       new_variant.save
       if new_variant.persisted?
         if entry.attributes['on_demand'].present?