Merge pull request openfoodfoundation#11837 from binarygit/open-link-…

…in-new-page Open external link in product description inside new page
abdellani · Nov 28, 2023 · d4cebfd · d4cebfd
2 parents 40742d6 + 208cad9
commit d4cebfd
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/app/views/shop/products/_summary.html.haml b/app/views/shop/products/_summary.html.haml
@@ -10,7 +10,7 @@
       %h3
         %a{"ng-click" => "triggerProductModal()", href: 'javascript:void(0)'}
           %span{"ng-bind" => "::product.name"}
-      .product-description{ng: {"bind-html": "::product.description_html", click: "triggerProductModal()", show: "product.description_html.length"}}
+      .product-description{ng: {"bind-html": "::product.description_html", click: "triggerProductModal()", show: "product.description_html.length"}, "data-controller": "add-blank-to-link"}
       %div{ "ng-switch" => "enterprise.visible" }
         .product-producer
           = t :products_from

diff --git a/spec/system/consumer/shopping/products_spec.rb b/spec/system/consumer/shopping/products_spec.rb
@@ -113,6 +113,14 @@
           expect(page).to have_content "alert('Dangerous!'); Safe"
         end
       end
+
+      it "opens link in product description inside another window" do
+        product.description = "<a href='https://api.rubyonrails.org/'>external site</a>"
+        product.save!
+
+        visit shop_path
+        expect(find_link('external site')[:target]).to eq('_blank')
+      end
     end
 
     describe "filtering" do