-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX] Multiple parameters for route_v8 #84
[FIX] Multiple parameters for route_v8 #84
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #84 +/- ##
=======================================
Coverage 92.98% 92.99%
=======================================
Files 26 26
Lines 1754 1755 +1
=======================================
+ Hits 1631 1632 +1
Misses 123 123
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
herepy/__init__.py
Outdated
@@ -6,7 +6,7 @@ | |||
__email__ = "[email protected]" | |||
__copyright__ = "Copyright (c) 2017 Abdullah Selek" | |||
__license__ = "MIT License" | |||
__version__ = "3.6.4" | |||
__version__ = "3.6.5" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we need to bump the version as 3.6.4
is not released yet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry! I also bumped the version in #82 ...
herepy/utils.py
Outdated
for key, value in parameters.items(): | ||
if isinstance(value, dict): | ||
for key2, val2 in value.items(): | ||
res[f"{key}[{key2}]"] = val2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please format the code, I can see an extra space before val2
. And also use better variable names for key2
and val2
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done, thanks.
eaeca38
to
918b954
Compare
918b954
to
e1e01ff
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fixes! Looks good to me.
encode_parameters
method, so it processes dict parameters correctly. Here API expects multi-level dict to be expressed askey[sub1]=val1&key[sub2]=val2
. The method supports only one level sub-dict, which as far as I know, should be enough.route_v8
-avoid
,exclude
andtruck
parameters were not fully supported.Fixes #83