Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Support passing headers in route_v8 #86

Conversation

maciej-wichowski
Copy link
Contributor

In route_v8 there is an option to pass custom headers to http request. However it was not actually passed.

@codecov-commenter
Copy link

codecov-commenter commented Oct 18, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.99%. Comparing base (a9a623f) to head (2288049).
Report is 4 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #86   +/-   ##
=======================================
  Coverage   92.99%   92.99%           
=======================================
  Files          26       26           
  Lines        1755     1755           
=======================================
  Hits         1632     1632           
  Misses        123      123           
Flag Coverage Δ
unittests 92.99% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@abdullahselek abdullahselek self-assigned this Oct 19, 2024
@abdullahselek abdullahselek merged commit 878aa65 into abdullahselek:master Oct 19, 2024
21 of 22 checks passed
@maciej-wichowski maciej-wichowski deleted the fix-route_v8_headers_in_request branch October 21, 2024 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants