Skip to content

Commit

Permalink
Merge pull request #112 from ionic-team/master
Browse files Browse the repository at this point in the history
pull master
  • Loading branch information
abennouna authored Nov 27, 2019
2 parents 746c4a9 + d8161bc commit c9103c8
Show file tree
Hide file tree
Showing 110 changed files with 2,741 additions and 654 deletions.
53 changes: 53 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,56 @@
# [5.0.0-beta.1](https://github.com/ionic-team/ionic/compare/v5.0.0-beta.0...v5.0.0-beta.1) (2019-11-20)


### Bug Fixes

* **animation:** track correctly when updating CSS Animation ([#19813](https://github.com/ionic-team/ionic/issues/19813)) ([7bd4412](https://github.com/ionic-team/ionic/commit/7bd44128895b9fa4992142c0cc30cf75092cb794))
* **card:** update background to use the same as item ([#19602](https://github.com/ionic-team/ionic/issues/19602)) ([1a8b7a4](https://github.com/ionic-team/ionic/commit/1a8b7a4559860b3efa4778a78c905e30f18587bf))
* **content:** set fixed content to position absolute ([#19867](https://github.com/ionic-team/ionic/issues/19867)) ([fce3e24](https://github.com/ionic-team/ionic/commit/fce3e24600be6f04b285cda62fe2f21c49d809e2)), closes [#17754](https://github.com/ionic-team/ionic/issues/17754)
* **gesture:** release gesture when disabling ([#19855](https://github.com/ionic-team/ionic/issues/19855)) ([21484f1](https://github.com/ionic-team/ionic/commit/21484f1f3a9ebe46096c979fe3f2035892a53a62)), closes [#19848](https://github.com/ionic-team/ionic/issues/19848)
* **header:** avoid flicker on collapsible header load ([#19682](https://github.com/ionic-team/ionic/issues/19682)) ([0a7aae2](https://github.com/ionic-team/ionic/commit/0a7aae28a7eb0270cdcd100933c01850403b66db))
* **header:** avoid flicker when collapsing ([#19850](https://github.com/ionic-team/ionic/issues/19850)) ([a3666dd](https://github.com/ionic-team/ionic/commit/a3666ddf0ccc44c696121a8d6107015dbe7aeabb)), closes [#19839](https://github.com/ionic-team/ionic/issues/19839)
* **header:** support collapsible header with multiple toolbars ([#19909](https://github.com/ionic-team/ionic/issues/19909)) ([fc4bb2d](https://github.com/ionic-team/ionic/commit/fc4bb2db5c5715841347135bdfa1bf66718d647d))
* **header:** translucent toolbars now work with collapsible header ([#19774](https://github.com/ionic-team/ionic/issues/19774)) ([b642b53](https://github.com/ionic-team/ionic/commit/b642b532e8846042f1317dc936191d0934b23945)), closes [#19773](https://github.com/ionic-team/ionic/issues/19773)
* **title:** only animate large title if back button is in start slot ([#19846](https://github.com/ionic-team/ionic/issues/19846)) ([cace1b3](https://github.com/ionic-team/ionic/commit/cace1b357e5acd54d49f2b662ecee5de90add708)), closes [#19840](https://github.com/ionic-team/ionic/issues/19840)
* **nav-params:** set generic type on navigation parameters get() ([#19195](https://github.com/ionic-team/ionic/issues/19195)) ([504051d](https://github.com/ionic-team/ionic/commit/504051d709c8afe08d588747866d2ee924baf804))
* **picker:** pass data and role to dismiss ([#19787](https://github.com/ionic-team/ionic/issues/19787)) ([7988720](https://github.com/ionic-team/ionic/commit/7988720b1cf46a651d9c140f0fe95726d3feb48c)), closes [#18454](https://github.com/ionic-team/ionic/issues/18454)
* **searchbar:** use back button config value for cancel icon ([#19353](https://github.com/ionic-team/ionic/issues/19353)) ([3d6f3b9](https://github.com/ionic-team/ionic/commit/ed6f3b9f3f42ef85f3f2d083fa7fe37a69b491c8))
* **textarea:** remove padding from textarea placeholder ([#19694](https://github.com/ionic-team/ionic/issues/19694)) ([f63d37a](https://github.com/ionic-team/ionic/commit/f63d37a4c506801a19b9bf6e5ef05d415d680b0c)), closes [#19616](https://github.com/ionic-team/ionic/issues/19616)
* **toast:** call button handler on cancel ([#19793](https://github.com/ionic-team/ionic/issues/19793)) ([420aa66](https://github.com/ionic-team/ionic/commit/420aa6639214e7d2e7b7413e699ace3d7fd35e40)), closes [#19791](https://github.com/ionic-team/ionic/issues/19791)



### Features

* **animation:** animation identifiers ([#19771](https://github.com/ionic-team/ionic/issues/19771)) ([7d41715](https://github.com/ionic-team/ionic/commit/7d417154c5f1ba89e0a30084807ff7e164dd6eba)), closes [#19550](https://github.com/ionic-team/ionic/issues/19550)
* **animation:** cubic-bezier easing conversion utility (experimental) ([#19788](https://github.com/ionic-team/ionic/issues/19788)) ([96a5e60](https://github.com/ionic-team/ionic/commit/96a5e600e563489d93a26d5956d210f246f6fea5)), closes [#19789](https://github.com/ionic-team/ionic/issues/19789)
* **alert:** add support for textarea inputs ([#16851](https://github.com/ionic-team/ionic/issues/16851)) ([b28cf02](https://github.com/ionic-team/ionic/commit/b28cf02ef3979c844c498a8e30ee977937984828)), closes [#14153](https://github.com/ionic-team/ionic/issues/14153)
* **angular:** expose Ionic Animations via AnimationController ([#19745](https://github.com/ionic-team/ionic/issues/19745)) ([67a7e23](https://github.com/ionic-team/ionic/commit/67a7e232b9058620653feec5ed99e0ebf22b6620))
* **angular:** expose Ionic Gestures via GestureController ([#19864](https://github.com/ionic-team/ionic/issues/19864)) ([48a7662](https://github.com/ionic-team/ionic/commit/48a766246d08170c709345bba235275eef0bd020))
* **searchbar:** add --box-shadow variable to style searchbar input ([#19838](https://github.com/ionic-team/ionic/issues/19838)) ([1ab7066](https://github.com/ionic-team/ionic/commit/1ab7066aa085bc0185a6dd3d162439f7f82415fa))
* **select:** add --placeholder-opacity and --placeholder-color, expose shadow parts ([#19893](https://github.com/ionic-team/ionic/issues/19893)) ([bef0f53](https://github.com/ionic-team/ionic/commit/bef0f53d0dcb15c58221c2dec8c4c274d3b5c77e)), closes [#17446](https://github.com/ionic-team/ionic/issues/17446)
* **split-pane:** convert to shadow component, add width, max-width, and min-width vars ([#19754](https://github.com/ionic-team/ionic/issues/19754)) ([d80f455](https://github.com/ionic-team/ionic/commit/d80f45516d5dca62b77db1773206ef274d42f3ef)), closes [#17088](https://github.com/ionic-team/ionic/issues/17088)



### Breaking Changes

> We recommend updating to the latest version of 4.x before trying out version 5 in order to see deprecation warnings related to your app in the console.

* **back-button:** convert back button to shadow ([#19411](https://github.com/ionic-team/ionic/pull/19411)) ([0d40d3f](https://github.com/ionic-team/ionic/commit/0d40d3f3b72aac7932ac71e6573d8bbb65a01515))
* **ionicons:** update to Ionicons v5. See https://ionicons.com for more information. ([#19670](https://github.com/ionic-team/ionic/pull/19670)) ([69e10de](https://github.com/ionic-team/ionic/commit/69e10de718dcba4d43e82bd37aeacd2585dd9a79))
* **list-header:** redesign list header to match latest iOS spec ([#19915](https://github.com/ionic-team/ionic/issues/19915)) ([5bbb95f](https://github.com/ionic-team/ionic/commit/5bbb95fae1e371021d6a0edc17fbb021a598b285))
* **split-pane:** convert split-pane to shadow ([#19754](https://github.com/ionic-team/ionic/issues/19754)) ([d80f455](https://github.com/ionic-team/ionic/commit/d80f45516d5dca62b77db1773206ef274d42f3ef))


## [4.11.5](https://github.com/ionic-team/ionic/compare/v4.11.0...v4.11.5) (2019-11-14)


### Bug Fixes

* **react:** improved lifecycle hooks to deal with stale closures, fixes [#19873](https://github.com/ionic-team/ionic/issues/19873) ([#19874](https://github.com/ionic-team/ionic/issues/19874)) ([5ff786a](https://github.com/ionic-team/ionic/commit/5ff786a23d5aa32281bbf5daaa7f8156de39caca))


## [4.11.4](https://github.com/ionic-team/ionic/compare/v4.11.1...v4.11.4) (2019-11-07)


Expand Down
4 changes: 2 additions & 2 deletions angular/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@ionic/angular",
"version": "5.0.0-beta.0",
"version": "5.0.0-beta.1",
"description": "Angular specific wrappers for @ionic/core",
"keywords": [
"ionic",
Expand Down Expand Up @@ -49,7 +49,7 @@
"css/"
],
"dependencies": {
"@ionic/core": "5.0.0-beta.0",
"@ionic/core": "5.0.0-beta.1",
"tslib": "^1.9.3"
},
"peerDependencies": {
Expand Down
4 changes: 2 additions & 2 deletions angular/src/directives/proxies.ts
Original file line number Diff line number Diff line change
Expand Up @@ -442,15 +442,15 @@ proxyMethods(IonList, ['closeSlidingItems']);
proxyInputs(IonList, ['inset', 'lines', 'mode']);

export declare interface IonListHeader extends Components.IonListHeader {}
@Component({ selector: 'ion-list-header', changeDetection: ChangeDetectionStrategy.OnPush, template: '<ng-content></ng-content>', inputs: ['color', 'mode'] })
@Component({ selector: 'ion-list-header', changeDetection: ChangeDetectionStrategy.OnPush, template: '<ng-content></ng-content>', inputs: ['color', 'lines', 'mode'] })
export class IonListHeader {
protected el: HTMLElement;
constructor(c: ChangeDetectorRef, r: ElementRef, protected z: NgZone) {
c.detach();
this.el = r.nativeElement;
}
}
proxyInputs(IonListHeader, ['color', 'mode']);
proxyInputs(IonListHeader, ['color', 'lines', 'mode']);

export declare interface IonMenu extends Components.IonMenu {}
@Component({ selector: 'ion-menu', changeDetection: ChangeDetectionStrategy.OnPush, template: '<ng-content></ng-content>', inputs: ['contentId', 'disabled', 'maxEdgeStart', 'menuId', 'side', 'swipeGesture', 'type'] })
Expand Down
2 changes: 1 addition & 1 deletion angular/src/providers/config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ export class Config {
}

set(key: keyof IonicConfig, value?: any) {
console.warn(`[DEPRECATION][Config]: The Config.set() method is deprecated and will be removed in the next major release.`);
console.warn(`[DEPRECATION][Config]: The Config.set() method is deprecated and will be removed in Ionic Framework 6.0. Please see https://ionicframework.com/docs/angular/config for alternatives.`);
const c = getConfig();
if (c) {
c.set(key, value);
Expand Down
13 changes: 9 additions & 4 deletions core/api.txt
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ ion-app,none
ion-avatar,shadow
ion-avatar,css-prop,--border-radius

ion-back-button,scoped
ion-back-button,shadow
ion-back-button,prop,color,string | undefined,undefined,false,false
ion-back-button,prop,defaultHref,string | undefined,undefined,false,false
ion-back-button,prop,disabled,boolean,false,false,true
Expand Down Expand Up @@ -465,7 +465,7 @@ ion-item,shadow
ion-item,prop,button,boolean,false,false,false
ion-item,prop,color,string | undefined,undefined,false,false
ion-item,prop,detail,boolean | undefined,undefined,false,false
ion-item,prop,detailIcon,string,'ios-arrow-forward',false,false
ion-item,prop,detailIcon,string,'chevron-forward',false,false
ion-item,prop,disabled,boolean,false,false,false
ion-item,prop,download,string | undefined,undefined,false,false
ion-item,prop,href,string | undefined,undefined,false,false
Expand Down Expand Up @@ -566,9 +566,14 @@ ion-list,method,closeSlidingItems,closeSlidingItems() => Promise<boolean>

ion-list-header,shadow
ion-list-header,prop,color,string | undefined,undefined,false,false
ion-list-header,prop,lines,"full" | "inset" | "none" | undefined,undefined,false,false
ion-list-header,prop,mode,"ios" | "md",undefined,false,false
ion-list-header,css-prop,--background
ion-list-header,css-prop,--border-color
ion-list-header,css-prop,--border-style
ion-list-header,css-prop,--border-width
ion-list-header,css-prop,--color
ion-list-header,css-prop,--inner-border-width

ion-loading,scoped
ion-loading,prop,animated,boolean,true,false,false
Expand Down Expand Up @@ -942,7 +947,7 @@ ion-searchbar,scoped
ion-searchbar,prop,animated,boolean,false,false,false
ion-searchbar,prop,autocomplete,"off" | "on",'off',false,false
ion-searchbar,prop,autocorrect,"off" | "on",'off',false,false
ion-searchbar,prop,cancelButtonIcon,string,config.get('backButtonIcon', 'md-arrow-back') as string,false,false
ion-searchbar,prop,cancelButtonIcon,string,config.get('backButtonIcon', 'arrow-back-sharp') as string,false,false
ion-searchbar,prop,cancelButtonText,string,'Cancel',false,false
ion-searchbar,prop,clearIcon,string | undefined,undefined,false,false
ion-searchbar,prop,color,string | undefined,undefined,false,false
Expand All @@ -951,7 +956,7 @@ ion-searchbar,prop,disabled,boolean,false,false,false
ion-searchbar,prop,inputmode,"decimal" | "email" | "none" | "numeric" | "search" | "tel" | "text" | "url",'search',false,false
ion-searchbar,prop,mode,"ios" | "md",undefined,false,false
ion-searchbar,prop,placeholder,string,'Search',false,false
ion-searchbar,prop,searchIcon,string,'search',false,false
ion-searchbar,prop,searchIcon,string | undefined,undefined,false,false
ion-searchbar,prop,showCancelButton,"always" | "focus" | "never",'never',false,false
ion-searchbar,prop,spellcheck,boolean,false,false,false
ion-searchbar,prop,type,"email" | "number" | "password" | "search" | "tel" | "text" | "url",'search',false,false
Expand Down
4 changes: 2 additions & 2 deletions core/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@ionic/core",
"version": "5.0.0-beta.0",
"version": "5.0.0-beta.1",
"description": "Base components for Ionic",
"keywords": [
"ionic",
Expand Down Expand Up @@ -30,7 +30,7 @@
"loader/"
],
"dependencies": {
"ionicons": "^4.6.3",
"ionicons": "^5.0.0-13",
"tslib": "^1.10.0"
},
"devDependencies": {
Expand Down
28 changes: 18 additions & 10 deletions core/src/components.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1199,6 +1199,10 @@ export namespace Components {
*/
'color'?: Color;
/**
* How the bottom border should be displayed on the list header.
*/
'lines'?: 'full' | 'inset' | 'none';
/**
* The mode determines which platform styles to use.
*/
'mode'?: "ios" | "md";
Expand Down Expand Up @@ -2137,15 +2141,15 @@ export namespace Components {
*/
'autocorrect': 'on' | 'off';
/**
* Set the cancel button icon. Only applies to `md` mode.
* Set the cancel button icon. Only applies to `md` mode. Defaults to `"arrow-back-sharp"`.
*/
'cancelButtonIcon': string;
/**
* Set the the cancel button text. Only applies to `ios` mode.
*/
'cancelButtonText': string;
/**
* Set the clear icon. Defaults to `"close-circle"` for `ios` and `"close"` for `md`.
* Set the clear icon. Defaults to `"close-circle"` for `ios` and `"close-sharp"` for `md`.
*/
'clearIcon'?: string;
/**
Expand Down Expand Up @@ -2177,9 +2181,9 @@ export namespace Components {
*/
'placeholder': string;
/**
* The icon to use as the search icon.
* The icon to use as the search icon. Defaults to `"search-outline"` in `ios` mode and `"search-sharp"` in `md` mode.
*/
'searchIcon': string;
'searchIcon'?: string;
/**
* Sets focus on the specified `ion-searchbar`. Use this method instead of the global `input.focus()`.
*/
Expand Down Expand Up @@ -4440,7 +4444,7 @@ declare namespace LocalJSX {
*/
'onIonFocus'?: (event: CustomEvent<void>) => void;
/**
* Emitted when a keyboard input ocurred.
* Emitted when a keyboard input occurred.
*/
'onIonInput'?: (event: CustomEvent<KeyboardEvent>) => void;
/**
Expand Down Expand Up @@ -4641,6 +4645,10 @@ declare namespace LocalJSX {
*/
'color'?: Color;
/**
* How the bottom border should be displayed on the list header.
*/
'lines'?: 'full' | 'inset' | 'none';
/**
* The mode determines which platform styles to use.
*/
'mode'?: "ios" | "md";
Expand Down Expand Up @@ -5362,15 +5370,15 @@ declare namespace LocalJSX {
*/
'autocorrect'?: 'on' | 'off';
/**
* Set the cancel button icon. Only applies to `md` mode.
* Set the cancel button icon. Only applies to `md` mode. Defaults to `"arrow-back-sharp"`.
*/
'cancelButtonIcon'?: string;
/**
* Set the the cancel button text. Only applies to `ios` mode.
*/
'cancelButtonText'?: string;
/**
* Set the clear icon. Defaults to `"close-circle"` for `ios` and `"close"` for `md`.
* Set the clear icon. Defaults to `"close-circle"` for `ios` and `"close-sharp"` for `md`.
*/
'clearIcon'?: string;
/**
Expand Down Expand Up @@ -5414,15 +5422,15 @@ declare namespace LocalJSX {
*/
'onIonFocus'?: (event: CustomEvent<void>) => void;
/**
* Emitted when a keyboard input ocurred.
* Emitted when a keyboard input occurred.
*/
'onIonInput'?: (event: CustomEvent<KeyboardEvent>) => void;
/**
* Set the input's placeholder. `placeholder` can accept either plaintext or HTML as a string. To display characters normally reserved for HTML, they must be escaped. For example `<Ionic>` would become `&lt;Ionic&gt;` For more information: [Security Documentation](https://ionicframework.com/docs/faq/security)
*/
'placeholder'?: string;
/**
* The icon to use as the search icon.
* The icon to use as the search icon. Defaults to `"search-outline"` in `ios` mode and `"search-sharp"` in `md` mode.
*/
'searchIcon'?: string;
/**
Expand Down Expand Up @@ -5869,7 +5877,7 @@ declare namespace LocalJSX {
*/
'onIonFocus'?: (event: CustomEvent<void>) => void;
/**
* Emitted when a keyboard input ocurred.
* Emitted when a keyboard input occurred.
*/
'onIonInput'?: (event: CustomEvent<KeyboardEvent>) => void;
/**
Expand Down
4 changes: 2 additions & 2 deletions core/src/components/action-sheet/test/basic/index.html
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@
}
}, {
text: 'Play (open modal)',
icon: 'arrow-dropright-circle',
icon: 'chevron-forward-circle',
handler: () => {
console.log('Play clicked');
}
Expand Down Expand Up @@ -221,7 +221,7 @@
}
}, {
text: 'Play (open modal)',
icon: 'arrow-dropright-circle',
icon: 'chevron-forward-circle',
handler: () => {
console.log('Play clicked');
}
Expand Down
4 changes: 2 additions & 2 deletions core/src/components/action-sheet/test/standalone/index.html
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@
}
}, {
text: 'Play (open modal)',
icon: 'arrow-dropright-circle',
icon: 'chevron-forward-circle',
handler: () => {
console.log('Play clicked');
}
Expand Down Expand Up @@ -98,7 +98,7 @@
}
}, {
text: 'Play (open modal)',
icon: 'arrow-dropright-circle',
icon: 'chevron-forward-circle',
handler: () => {
console.log('Play clicked');
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@
}
}, {
text: 'Play (open modal)',
icon: 'arrow-dropright-circle',
icon: 'chevron-forward-circle',
handler: () => {
console.log('Play clicked');
}
Expand Down
2 changes: 1 addition & 1 deletion core/src/components/app/test/safe-area/index.html
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@
const toast = Object.assign(document.createElement('ion-toast'), {
message: 'Hello world!',
buttons: [
{ text: 'Close', role: 'close' }
{ text: 'Close', role: 'cancel' }
]
});
document.body.appendChild(toast);
Expand Down
1 change: 0 additions & 1 deletion core/src/components/back-button/back-button.scss
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,6 @@
// Back Button States
// --------------------------------------------------

:host-context(.can-go-back > ion-header),
:host(.show-back-button) {
display: block;
}
Expand Down
Loading

0 comments on commit c9103c8

Please sign in to comment.