Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deal with specs that don't contain tests #20

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

irfanhabib
Copy link

@irfanhabib irfanhabib commented Jan 17, 2017

This addresses a bug where tests suites that don't contain tests trip up the reporter.

For instance a jasmine specs like the following:

describe('test category', function(){
 describe('category A', function(){
  it(...);
  it(...)
 });
 describe('category b', function(){
   it(...);
   it(...)
 });
});

@wtreur
Copy link

wtreur commented Jul 21, 2017

It would be awesome if this could be merged soon. It's not nice to fill up my tests with empty it() blocks...

@adinapitul
Copy link

+1

@azachar
Copy link

azachar commented Dec 20, 2017

Hi there,

I forked the solution and fix this issue, have a look https://github.com/azachar/protractor-screenshoter-plugin

Cheers,
Andrej

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants