Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vm: support additional disks #893

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

ssakuh
Copy link

@ssakuh ssakuh commented Nov 19, 2023

adds support for a new parameter in colima.yaml that will create and mount additional disks via limactl

@abiosoft
Copy link
Owner

limactl disk create command is not idempotent. i.e. there needs to be a check if the disk does not exist before running the command.

@ssakuh ssakuh force-pushed the feat/additional-disks branch from e09ad4b to 7597068 Compare November 30, 2023 21:57
@ssakuh ssakuh force-pushed the feat/additional-disks branch from 7597068 to fb84658 Compare November 30, 2023 21:58
@ssakuh
Copy link
Author

ssakuh commented Nov 30, 2023

@abiosoft I have improved the implementation. please have a look

@abiosoft
Copy link
Owner

abiosoft commented Dec 6, 2023

Hi, thanks for your efforts so far.

Can you kindly limit this PR to only support additional disks? Other fixes can happen in a separate PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants