Update cmatrix.c #109
Open
Update cmatrix.c #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gcc compile error fixed.
gcc -DHAVE_CONFIG_H -I. -g -O2 -MT cmatrix.o -MD -MP -MF .deps/cmatrix.Tpo -c -o cmatrix.o cmatrix.c
cmatrix.c: In function ‘resize_screen’:
cmatrix.c:277:10: error: lvalue required as left operand of assignment
COLS = win.ws_col;
^
cmatrix.c:278:11: error: lvalue required as left operand of assignment
LINES = win.ws_row;
^
cmatrix.c:282:15: error: lvalue required as left operand of assignment
LINES = 10;
^
cmatrix.c:285:14: error: lvalue required as left operand of assignment
COLS = 10;
|
Changing an assignment to a comparison isn't much of a fix, in my opinion. You're just avoiding the issue altogether. |
abishekvashok
requested changes
Dec 12, 2020
There was a problem hiding this comment.
Heyya, I tried this patch and its not resizing on my machine. Can you pls check on it. There seems to be a suggestion by @space-pagan as well ~ maybe give it a go!
abishekvashok
added
the
Changes requested
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gcc compile error fixed.
gcc -DHAVE_CONFIG_H -I. -g -O2 -MT cmatrix.o -MD -MP -MF .deps/cmatrix.Tpo -c -o cmatrix.o cmatrix.c
cmatrix.c: In function ‘resize_screen’:
cmatrix.c:277:10: error: lvalue required as left operand of assignment
COLS = win.ws_col;
^
cmatrix.c:278:11: error: lvalue required as left operand of assignment
LINES = win.ws_row;
^
cmatrix.c:282:15: error: lvalue required as left operand of assignment
LINES = 10;
^
cmatrix.c:285:14: error: lvalue required as left operand of assignment
COLS = 10;