This repository has been archived by the owner on Oct 30, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 9
WIP: react-hooks v3 main branch #68
Draft
ttypic
wants to merge
61
commits into
main
Choose a base branch
from
integration/v3
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add eslint and prettier config and CI steps
adds an ably context provider which makes an ably client available via a useAbly hook. the hook is used by useChannel and usePresence instead of the existing `configureAbly` and `provideAbly` functions. in order to properly support multiple clients (and potentially nested <AblyProvider>s), an optional string id prop is available to set ids which can be passed to useChannel, usePresence, and useAbly to specify a particular client/context.
feat!: add `<AblyProvider>` and `useAbly`
this functionality is covered by the listener hooks and it's straightforward enough to get the same behaviour by just updating a `useState` inside the listener function so i'm removing these for now just for simplicity.
gives the user full control over whether their component re-renders
…hannelState feat: add `useChannelStateListener` and `useConnectionStateListener` hooks
# Conflicts: # src/AblyReactHooks.ts # src/hooks/usePresence.ts
update `integration/v3` branch with the most recent commits from `main`
These are outdated since the new way to provide a realtime client to the library is by using the `AblyProvider` component
docs: update contribution guide link
* removed `eslint-config-airbnb` * added recommended rules for `react-hooks` * turned on all recommended rules, except `@typescript-eslint/no-explicit-any` and `prefer-spread` (those require some additional refactoring)
chore(eslint): ESLint linting improvements
docs: remove outdated docs for passing in realtime instance
feat!: add React 16.8+ support for the library
fix: using stale version of message callback for `useChannel` hook
…ions fix: make AblyProvider work with options parameter
fix: use fully qualified imports with `.js` extension for ESM build
[SDK-3801] feat: skip param for usePresence and useChannel
docs: document requirement for client side rendering
[SDK-3784] docs: add migration guide
[SDK-3797] feat: send agent with `/time` request upon init
feat: allow useChannel without message callback
[SDK-3777] feat: ably-js peerDependency
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.