Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ECO-4717] Removed semaphore in favour of an atomic property for synchronised access. #1918

Merged
merged 1 commit into from
May 14, 2024
Merged

[ECO-4717] Removed semaphore in favour of an atomic property for synchronised access. #1918

merged 1 commit into from
May 14, 2024

Conversation

maratal
Copy link
Collaborator

@maratal maratal commented May 13, 2024

Closes #1897

@github-actions github-actions bot temporarily deployed to staging/pull/1918/features May 13, 2024 00:14 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1918/jazzydoc May 13, 2024 00:18 Inactive
@maratal maratal force-pushed the fix/1897-remove-semaphore branch from 87f5bac to 33af3c8 Compare May 13, 2024 10:37
@maratal maratal marked this pull request as ready for review May 13, 2024 11:31
@maratal maratal requested review from sacOO7 and umair-ably May 13, 2024 11:31
@maratal maratal changed the title Removed semaphore in favour of an atomic property for synchronised access. [ECO-4717] Removed semaphore in favour of an atomic property for synchronised access. May 13, 2024
@maratal
Copy link
Collaborator Author

maratal commented May 13, 2024

Related #1100

sacOO7
sacOO7 approved these changes May 14, 2024
View reviewed changes
Copy link
Contributor

@sacOO7 sacOO7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not aware about synchronisation/multithreading functionality in objective/c. But atomic property probably should handle the issue.
@maratal it will be great if we can add test for the same.

@maratal maratal mentioned this pull request May 14, 2024
Open
@maratal
Copy link
Collaborator Author

maratal commented May 14, 2024

I am not aware about synchronisation/multithreading functionality in objective/c. But atomic property probably should handle the issue. @maratal it will be great if we can add test for the same.

Thanks @sacOO7, created an issue for this - #1919

@maratal maratal merged commit 465184b into main May 14, 2024
7 checks passed
@maratal maratal deleted the fix/1897-remove-semaphore branch May 14, 2024 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sacOO7 sacOO7 sacOO7 approved these changes

@umair-ably umair-ably Awaiting requested review from umair-ably

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Thread priority inversion runtime warning
2 participants
@maratal @sacOO7