Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactored IOC class, Platform clases and updated ablyrealtime and ablyrest for the same #1254

Merged
merged 12 commits into from
Aug 13, 2023
Merged
Prev Previous commit
Next Next commit
Unskipped localdevice flaky tests
sacOO7 committed Aug 12, 2023
commit 9afbfdf76bbce6c0e28ad0fb63ecf85b00c8057c
4 changes: 2 additions & 2 deletions src/IO.Ably.Tests.Shared/Push/LocalDeviceTests.cs
Original file line number Diff line number Diff line change
@@ -132,7 +132,7 @@ public void WhenPlatformsDoesNotSupportPushNotifications_DeviceShouldBeNull()
rest.MobileDevice.Should().BeNull();
}

[Fact(Skip = "Intermittently fails")]
[Fact]
[Trait("spec", "RSH8a")]
public void LocalDevice_IsOnlyInitialisedOnce()
{
@@ -157,7 +157,7 @@ public void LocalDevice_WhenInitialised_ShouldHave_CorrectProperties_set()
device.FormFactor.Should().NotBeEmpty();
}

[Fact(Skip = "Intermittently fails")]
[Fact]
[Trait("spec", "RSH8a")]
[Trait("spec", "RSH8b")]
public void LocalDevice_WhenRestClientContainsClientId_ShouldHaveTheSameClientId()