Skip to content

docs: update permission section in PushNotifications documentation #546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ttypic
Copy link
Contributor

@ttypic ttypic commented Sep 18, 2024

Updated permission section in PushNotifications documentation:

  • added recommendation to use permission_handler package
  • marked old iOS only solution as deprecated
  • add link to the refactoring issue

Summary by CodeRabbit

  • Documentation
    • Enhanced guidance on notification permissions management, recommending the permission_handler Flutter package for cross-platform support.
    • Added example code for requesting notification permissions on both iOS and Android.
    • Included a deprecation notice for the built-in notification permissions management on iOS.
    • Noted upcoming utility function for simplified notification permissions handling within the SDK.

Copy link

coderabbitai bot commented Sep 18, 2024

Walkthrough

The changes expand and restructure the PushNotifications.md documentation to cover notification permissions on both iOS and Android. It recommends the permission_handler Flutter package for cross-platform permission requests, marks the built-in iOS-only permission method as deprecated, and notes a forthcoming SDK utility for unified permission handling.

Changes

Files Change Summary
PushNotifications.md - Expanded notification permissions section to include Android and iOS.
- Recommended permission_handler Flutter package with example code for requesting permissions.
- Deprecated built-in iOS-only notification permission request method with warning and explanation.
- Added note about upcoming SDK utility function for cross-platform notification permission management.

Poem

In the meadow where bunnies play,
Permissions now lead the way! 🐇✨
With flutter-permission-handler in sight,
Notifications will work just right.
A hop, a skip, to code we go,
Simplified paths, watch our skills grow! 🌼


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 718964d and 66489ff.

📒 Files selected for processing (1)
  • PushNotifications.md (2 hunks)
✅ Files skipped from review due to trivial changes (1)
  • PushNotifications.md
⏰ Context from checks skipped due to timeout of 90000ms (5)
  • GitHub Check: android (29)
  • GitHub Check: android
  • GitHub Check: android (24)
  • GitHub Check: ios (iPhone 15)
  • GitHub Check: ios
✨ Finishing Touches
🧪 Generate Unit Tests
  • Create PR with Unit Tests
  • Post Copyable Unit Tests in Comment
  • Commit Unit Tests in branch update-push-docs

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai auto-generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot temporarily deployed to staging/pull/546/features September 18, 2024 10:20 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/546/dartdoc September 18, 2024 10:20 Inactive
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 4

Outside diff range and nitpick comments (3)
PushNotifications.md (3)

192-193: Ensure Consistent Heading Capitalization

The heading "Notification Permissions using permission_handler package" should use Title Case for consistency with the rest of the document. Consider capitalizing "Using" to match the style of other headings.

Apply this diff to correct the heading capitalization:

-#### Notification Permissions using `permission_handler` package
+#### Notification Permissions Using `permission_handler` Package

194-194: Remove Extra Space Between Words

There's an extra space between "the" and the [flutter-permission-handler] link. Removing it will improve readability.

Apply this diff:

-However, we recommend using the  [flutter-permission-handler](https://github.com/baseflow/flutter-permission-handler) package due to its reliable cross-platform support for both iOS and Android.
+However, we recommend using the [flutter-permission-handler](https://github.com/baseflow/flutter-permission-handler) package due to its reliable cross-platform support for both iOS and Android.

216-216: Ensure Consistent Heading Capitalization

For consistency, capitalize "iOS Only" in the heading.

Apply this diff:

-#### Built-in Notification Permissions Management (iOS only)
+#### Built-in Notification Permissions Management (iOS Only)
Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between c6a780f and 76949d8.

Files selected for processing (1)
  • PushNotifications.md (2 hunks)

@github-actions github-actions bot temporarily deployed to staging/pull/546/dartdoc September 18, 2024 10:42 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/546/features September 18, 2024 10:42 Inactive
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Outside diff range and nitpick comments (1)
PushNotifications.md (1)

Line range hint 229-254: Update documentation to reflect deprecation of Push#requestPermission method

After marking the Push#requestPermission method as deprecated, the documentation should be updated to guide users towards the recommended alternative for handling notification permissions on iOS. Continuing to instruct users to use a deprecated method may cause confusion.

Apply this diff to update the documentation:

-// Create an Ably client to access the push field
-final realtime = ably.Realtime(options: clientOptions);
-final push = realtime.push;
-// Request permission from user on iOS
-bool permissionGranted = await push.requestPermission();
-// Get more information about the notification settings
-if (Platform.isIOS) {
-  final notificationSettings = await realtime.push.getNotificationSettings();
-}
+// Request notification permission
+PermissionStatus status = await Permission.notification.request();
+
+if (status.isGranted) {
+  // Handle permission granted
+} else {
+  // Handle permission denied
+}
Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 76949d8 and 718964d.

Files selected for processing (1)
  • PushNotifications.md (2 hunks)

@ttypic ttypic requested a review from sacOO7 September 18, 2024 11:13
@github-actions github-actions bot temporarily deployed to staging/pull/546/dartdoc October 9, 2024 11:02 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/546/features October 9, 2024 11:02 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/546/dartdoc October 14, 2024 11:51 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/546/features October 14, 2024 11:51 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant