-
Notifications
You must be signed in to change notification settings - Fork 45
[EDU-2056] Add webhook concurrency limit #2798
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
| ----------------- | ---- | -------- | --- | ---------- | | ||
| **Integration rate (per second)**<p>*the maximum rate at which integrations can be executed, or streamed*</p> | 250 | 250 | 1,000 | Custom | | ||
| **Integration concurrency (Google Functions and Azure)**<p>*the maximum number of integrations that can run at the same time*</p> | 25 | 25 | 100 | Custom | | ||
| **Webhook concurrency**<p>*the maximum number of webhook requests that can be processed at the same time*</p> | 25 | 25 | 100 | Custom | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the maximum number of webhook requests that can be processed at the same time
Not sure this captures it. It implies we're processing something, but the whole point with this limit is that it's the customer processing it. Maybe "The maximum number of unbatched webhook requests that can be in-flight at any one time from a given source"?
Also I'm not sure I understand the reasoning for presenting this one limit as two different ones.
(and indeed the one above is probably out of date since the limit only applies to http1 unbatched webhooks but google functions and azure endpoints probably accept http2 these days)
Description
This PR adds a missing limit for webhook concurrency to the limits page.
Checklist