Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Locking demo #111

Merged
merged 22 commits into from
Aug 25, 2023
Merged

Locking demo #111

merged 22 commits into from
Aug 25, 2023

Conversation

dpiatek
Copy link
Contributor

@dpiatek dpiatek commented Aug 11, 2023

No description provided.

@ttypic ttypic marked this pull request as ready for review August 21, 2023 09:35
@ttypic ttypic force-pushed the locking-demo branch 2 times, most recently from 177d055 to 1ce9f39 Compare August 21, 2023 12:35
@ttypic ttypic requested review from lmars and artismarti August 24, 2023 08:42
lmars
lmars reviewed Aug 24, 2023
View reviewed changes
Copy link
Member

@lmars lmars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have little experience with React, but I've commented specifically on the usage of the locks API

demo/src/hooks/useElementSelect.ts Outdated Show resolved Hide resolved
ttypic
ttypic reviewed Aug 24, 2023
View reviewed changes
demo/src/components/Paragraph.tsx Outdated Show resolved Hide resolved
demo/src/hooks/useSlideElementContent.ts Outdated Show resolved Hide resolved
artismarti
artismarti approved these changes Aug 25, 2023
View reviewed changes
Copy link

@artismarti artismarti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@ttypic ttypic merged commit 41255bc into main Aug 25, 2023
@ttypic ttypic deleted the locking-demo branch August 25, 2023 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ttypic ttypic ttypic left review comments

@lmars lmars lmars left review comments

@artismarti artismarti artismarti approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dpiatek @artismarti @lmars @ttypic