Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chat-spec] Removed transient timeout references for delayed ATTACHING state #264

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

sacOO7
Copy link
Collaborator

@sacOO7 sacOO7 commented Jan 9, 2025

@github-actions github-actions bot temporarily deployed to staging/pull/264 January 9, 2025 09:43 Inactive
@sacOO7
Copy link
Collaborator Author

sacOO7 commented Jan 9, 2025

@sacOO7 sacOO7 marked this pull request as ready for review January 9, 2025 11:08
@sacOO7 sacOO7 requested a review from ttypic January 9, 2025 11:08
textile/chat-features.textile Outdated Show resolved Hide resolved
textile/chat-features.textile Outdated Show resolved Hide resolved
textile/chat-features.textile Outdated Show resolved Hide resolved
@sacOO7
Copy link
Collaborator Author

sacOO7 commented Jan 10, 2025

@AndyTWF Btw, we should be creating new spec points instead of updating existing ones right?
Currently, I updated existing spec points for better understanding.

@AndyTWF
Copy link
Contributor

AndyTWF commented Jan 10, 2025

@AndyTWF Btw, we should be creating new spec points instead of updating existing ones right? Currently, I updated existing spec points for better understanding.

That's usually what we do, yes - though I'd say if Kotlin/Swift aren't implementing them yet, its probably ok to just update the existing.

@sacOO7 sacOO7 requested a review from AndyTWF January 13, 2025 10:45
@lawrence-forooghian
Copy link
Collaborator

I think we're at the point now where if we're going to change lifecycle spec points then we should follow the proper guidance for modification; I'm pretty sure that the spec points that you've changed here are already implemented in Swift so we shouldn't mutate them.

@sacOO7 sacOO7 force-pushed the refactor/room-monitoring-attaching-state-timeout branch from f6401a8 to b423482 Compare January 13, 2025 14:39
@sacOO7
Copy link
Collaborator Author

sacOO7 commented Jan 13, 2025

@lawrence-forooghian updated PR as per your suggestion 👍

@sacOO7 sacOO7 changed the title Removed transient timeout references for delayed ATTACHING state [chat-spec] Removed transient timeout references for delayed ATTACHING state Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

[chat-spec][Room monitoring] Remove or simplify transient detach timeout for room monitoring
3 participants