-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[chat-spec] Removed transient timeout references for delayed ATTACHING state #264
base: main
Are you sure you want to change the base?
Conversation
Link to active discussion -> https://ably-real-time.slack.com/archives/C03JDBVM5MY/p1736416097802209 |
@AndyTWF Btw, we should be creating new spec points instead of updating existing ones right? |
That's usually what we do, yes - though I'd say if Kotlin/Swift aren't implementing them yet, its probably ok to just update the existing. |
Co-authored-by: Andy Ford <[email protected]>
I think we're at the point now where if we're going to change lifecycle spec points then we should follow the proper guidance for modification; I'm pretty sure that the spec points that you've changed here are already implemented in Swift so we shouldn't mutate them. |
superseded by new ones for attaching timeout.
f6401a8
to
b423482
Compare
@lawrence-forooghian updated PR as per your suggestion 👍 |
transient disconnect timeout
in the context of transitioning state to ATTACHING is wrong.