Fix abo-abo/avy#369 #370
Open
Fix abo-abo/avy#369 #370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avy uses screen lines when visual-line-mode is active, but linum marks only logical lines, so the indicators do not match the actual characters avy will use to jump, when both visual-line-mode and avy-linum-mode is active. We're taking linum's side here, and not using the visual-line code branches in avy when avy-linum-mode is active. It would be nice if linum could be forced to accept avy's reality instead, perhaps having an option to choose which side to take with a variable, but unfortunately I didn't find anything that would suggest such configuration could be possible, neither in linum, nor in nlinum for that matter. I also wrapped one naked visual-line-mode condition in a (bound-and-true-p) for consistency; I'm not sure if that change is necessary, and it can be reverted in case of trouble. Signed-off-by: ghost-of-freedom <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avy uses screen lines when visual-line-mode is active, but linum marks only logical lines, so the indicators do not match the actual characters avy will use to jump, when both visual-line-mode and avy-linum-mode is active. We're taking linum's side here, and not using the visual-line code branches in avy when avy-linum-mode is active. It would be nice if linum could be forced to accept avy's reality instead, perhaps having an option to choose which side to take with a variable, but unfortunately I didn't find anything that would suggest such configuration could be possible, neither in linum, nor in nlinum for that matter.
I also wrapped one naked visual-line-mode condition in a (bound-and-true-p) for consistency; I'm not sure if that change is necessary, and it can be reverted in case of trouble.