Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unwanted dependencies #9

Merged
merged 3 commits into from
Sep 26, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
<parent>
<groupId>org.springframework.boot</groupId>
<artifactId>spring-boot-starter-parent</artifactId>
<version>3.3.3</version>
<version>3.3.4</version>
<relativePath/> <!-- lookup parent from repository -->
</parent>

Expand Down Expand Up @@ -89,6 +89,12 @@
<groupId>org.springframework.boot</groupId>
<artifactId>spring-boot-starter-test</artifactId>
<scope>test</scope>
<exclusions>
<exclusion>
<groupId>org.hamcrest</groupId>
<artifactId>hamcrest</artifactId>
</exclusion>
</exclusions>
</dependency>
<dependency>
<groupId>org.springframework.boot</groupId>
Expand Down Expand Up @@ -123,6 +129,12 @@
<groupId>org.hamcrest</groupId>
<artifactId>hamcrest-library</artifactId>
</exclusion>
<exclusion>
<!-- see: https://github.com/testcontainers/testcontainers-java/issues/970#issuecomment-625044008 -->
<!-- can be removed once testcontainers drop their dependency to junit4 -->
<groupId>junit</groupId>
<artifactId>junit</artifactId>
</exclusion>
</exclusions>
</dependency>
<dependency>
Expand Down
10 changes: 10 additions & 0 deletions src/test/java/org/junit/rules/TestRule.java
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
package org.junit.rules;

/**
* This is required by Testcontainers but actually unused.
* By defining this here, we can avoid loading Junit-4.
* See: https://github.com/testcontainers/testcontainers-java/issues/970#issuecomment-625044008
*/
@SuppressWarnings("unused")
public interface TestRule {
}
10 changes: 10 additions & 0 deletions src/test/java/org/junit/runners/model/Statement.java
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
package org.junit.runners.model;

/**
* This is required by Testcontainers but actually unused.
* By defining this here, we can avoid loading Junit-4.
* See: https://github.com/testcontainers/testcontainers-java/issues/970#issuecomment-625044008
*/
@SuppressWarnings("unused")
public class Statement {
}