Make safe filename safe to use on POSIX #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@JonoYang Do you mind to add a few tests so that we can merge this? |
Signed-off-by: Jono Yang <[email protected]>
Signed-off-by: Jono Yang <[email protected]>
Signed-off-by: Jono Yang <[email protected]>
JonoYang
force-pushed
the
posix-safe-filename
branch
from
58acb67
to
6434fdf
Compare
* Test posix_only argument for safe_path
* Update CHANGELOG.rst
Signed-off-by: Jono Yang <[email protected]>
JonoYang
force-pushed
the
posix-safe-filename
branch
from
b9f0457
to
b88d65a
Compare
|
@pombredanne I've added some test code that checks to see if |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables handling safe paths treating some extra characters as safe on POSIX.
In particular this ensures that we can treat the colon ":" as safe for use in file names
on POSIX only. This will allow correct processing of system files in ScanCode.io
and ExtractCode
Reference: aboutcode-org/extractcode#41
Reference: aboutcode-org/scancode.io#407
Reference: aboutcode-org/scancode.io#445