Merge pull request #184 from nexB/do-not-process-empty-filter-by-chec…

…ksum-request

Don't process empty request in filter_by_checksums

packagedb/api.py

@@ -144,14 +144,21 @@ def filter_by_checksums(self, request, *args, **kwargs):
             }
             return Response(response_data)
 
-        q = Q()
+        if not data:
+            response_data = {
+                'status': 'No values provided'
+            }
+            return Response(response_data)
+
+        lookups = Q()
         for field, value in data.items():
+            value = value or []
             # We create this intermediate dictionary so we can modify the field
             # name to have __in at the end
             d = {f'{field}__in': value}
-            q |= Q(**d)
+            lookups |= Q(**d)
 
-        qs = Resource.objects.filter(q)
+        qs = Resource.objects.filter(lookups)
         paginated_qs = self.paginate_queryset(qs)
         serializer = ResourceAPISerializer(paginated_qs, many=True, context={'request': request})
         return self.get_paginated_response(serializer.data)

packagedb/api_custom.py

@@ -13,10 +13,10 @@
 class PageSizePagination(PageNumberPagination):
     """
     Adds the page_size parameter. Default results per page is 10.
-    A page_size parameter can be provided, limited to 100 results per page max.
+    A page_size parameter can be provided, limited to 20 results per page max.
     For example:
-    http://api.example.org/accounts/?page=4&page_size=100
+    http://api.example.org/accounts/?page=4&page_size=20
     """
-    page_size = 100
-    max_page_size = 100
+    page_size = 20
+    max_page_size = 20
     page_size_query_param = 'page_size'

purldb/settings.py

@@ -248,7 +248,7 @@
     ),
     'DEFAULT_PAGINATION_CLASS': 'packagedb.api_custom.PageSizePagination',
     # Limit the load on the Database returning a small number of records by default. https://github.com/nexB/vulnerablecode/issues/819
-    "PAGE_SIZE": 100,
+    "PAGE_SIZE": 20,
 }
 
 if not PURLDB_REQUIRE_AUTHENTICATION: