Update maven download urls #208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonoYang
force-pushed
the
update-maven-download-urls
branch
4 times, most recently
from
7b0a7fc to
146ca02
Compare
JonoYang
force-pushed
the
update-maven-download-urls
branch
from
7e13b87 to
142e7b0
Compare
Signed-off-by: Jono Yang <[email protected]>
Signed-off-by: Jono Yang <[email protected]>
Signed-off-by: Jono Yang <[email protected]>
Signed-off-by: Jono Yang <[email protected]>
Signed-off-by: Jono Yang <[email protected]>
Signed-off-by: Jono Yang <[email protected]>
Signed-off-by: Jono Yang <[email protected]>
* Do this when we cannot find a package download url using existing purl values Signed-off-by: Jono Yang <[email protected]>
Signed-off-by: Jono Yang <[email protected]>
* Create command to update or create package from the maven index Signed-off-by: Jono Yang <[email protected]>
Signed-off-by: Jono Yang <[email protected]>
Signed-off-by: Jono Yang <[email protected]>
Signed-off-by: Jono Yang <[email protected]>
* Append to ProcessError table whenever we encounter a package we cant create or update in update_maven_package_data Signed-off-by: Jono Yang <[email protected]>
* Deindent code block Signed-off-by: Jono Yang <[email protected]>
Signed-off-by: Jono Yang <[email protected]>
Signed-off-by: Jono Yang <[email protected]>
Signed-off-by: Jono Yang <[email protected]>
Signed-off-by: Jono Yang <[email protected]>
Signed-off-by: Jono Yang <[email protected]>
* Remove unused code Signed-off-by: Jono Yang <[email protected]>
JonoYang
force-pushed
the
update-maven-download-urls
branch
from
c8293d4 to
dc76cc2
Compare
* Remove vendored virtualenv.pyz Signed-off-by: Jono Yang <[email protected]>
AyanSinhaMahapatra
approved these changes
Jul 11, 2024
|
|
||
|
|
||
| # This is from https://stackoverflow.com/questions/4856882/limiting-memory-use-in-a-large-django-queryset/5188179#5188179 | ||
| class MemorySavingQuerysetIterator(object): |
There was a problem hiding this comment.
Is this being used here in this command?
Also maybe we want to have some sort of utils and have this class there as this can be used else where too, like it's used in packagedb/management/commands/fix_purl_values.py
There was a problem hiding this comment.
I've moved this to minecode/utils.py. This is only use in fix_purl_values.py for now, but I think this is a useful piece of code when we run into memory problems.
|
|
||
|
|
||
| def query_sha1_on_maven(sha1, timeout=DEFAULT_TIMEOUT): | ||
| maven_api_search_url = f'https://search.maven.org/solrsearch/select?q=1:{sha1}' |
There was a problem hiding this comment.
We have an issue here on this: #498 what do you think about this?
keshav-space
approved these changes
Jul 11, 2024
Signed-off-by: Jono Yang <[email protected]>
JonoYang
force-pushed
the
update-maven-download-urls
branch
from
e32299b to
4aa19f2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.