Detect installed windows programs #2582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pombredanne
requested changes
Jul 6, 2021
src/packagedcode/windows_helpers.py
Outdated
| # Remove leading drive letter ("C:\\") and replace all spaces with underscore | ||
| install_location_no_root = install_location.relative_to(*install_location.parts[:1]) | ||
| install_location_no_root = str(install_location_no_root) | ||
| install_location_no_root = install_location_no_root.replace(' ', '_') |
There was a problem hiding this comment.
This was a workaround that I have now removed. Extractcode would replace spaces in file/directory names and the code would not find the file on my system.
There was a problem hiding this comment.
| "purl": "pkg:windows-program/Python%203.9.5%20Tcl/Tk%20Support%20%2864-bit%[email protected]", | ||
| "repository_homepage_url": null, | ||
| "repository_download_url": null, | ||
| "api_data_url": null |
There was a problem hiding this comment.
What about the installed files?
|
Thanks! let me review now... Note that I created https://github.com/mkorman90/regipy/ as an example of a way to get fewer deps with regipy (and explicit support for Python 3.6 and 3.9 who both work fine with it) |
Signed-off-by: Jono Yang <[email protected]>
Signed-off-by: Jono Yang <[email protected]>
* Create get_msiinfo_bin_location() Signed-off-by: Jono Yang <[email protected]>
Signed-off-by: Jono Yang <[email protected]>
Signed-off-by: Jono Yang <[email protected]>
* Fix function that reports installed .NET versions Signed-off-by: Jono Yang <[email protected]>
Signed-off-by: Jono Yang <[email protected]>
Signed-off-by: Jono Yang <[email protected]>
* Collect installed file locations Signed-off-by: Jono Yang <[email protected]>
Signed-off-by: Jono Yang <[email protected]>
Signed-off-by: Jono Yang <[email protected]>
Signed-off-by: Jono Yang <[email protected]>
* Create get_registry_tree that returns a list of dicts that contain the registry entries
* report_dotnet_versions and report_installed_programs is now broken up into two parts, first is a call it get_registry_tree and a second is a call to _report_installed_programs or _report_dotnet_versions. These functions prefixed with underscores takes in a list of dictionaries
* Update tests by replacing the SOFTWARE registry file with json results
Signed-off-by: Jono Yang <[email protected]>
* Remove test MSI installer Signed-off-by: Jono Yang <[email protected]>
Signed-off-by: Jono Yang <[email protected]>
Signed-off-by: Jono Yang <[email protected]>
Signed-off-by: Jono Yang <[email protected]>
Signed-off-by: Jono Yang <[email protected]>
* Add cli tests for win_pe and mum package detection
* Update test results
Signed-off-by: Jono Yang <[email protected]>
JonoYang
force-pushed
the
2565-detect-installed-windows-programs
branch
from
cab062d
to
259d4a1
Compare
JonoYang
commented
Jul 14, 2021
| "contains_source_code": null, | ||
| "source_packages": [], | ||
| "extra_data": { | ||
| "install_location": "C:\\Program Files\\Test\\", |
There was a problem hiding this comment.
Consider posix-izing the path
* Output installed_files in test result files Signed-off-by: Jono Yang <[email protected]>
Signed-off-by: Jono Yang <[email protected]>
Signed-off-by: Jono Yang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enhances Windows package detection by introducing new functions that detects installed programs from Windows registry files.
Signed-off-by: Jono Yang [email protected]