-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unit tests #591
Unit tests #591
Conversation
Signed-off-by: Omkar Phansopkar <[email protected]>
Signed-off-by: Omkar Phansopkar <[email protected]>
Signed-off-by: Omkar Phansopkar <[email protected]>
Signed-off-by: Omkar Phansopkar <[email protected]>
Signed-off-by: Omkar Phansopkar <[email protected]>
Signed-off-by: Omkar Phansopkar <[email protected]>
Signed-off-by: Omkar Phansopkar <[email protected]>
…to feature/unittests
Signed-off-by: Omkar Phansopkar <[email protected]>
Signed-off-by: Omkar Phansopkar <[email protected]>
…to feature/unittests
Signed-off-by: Omkar Phansopkar <[email protected]>
Signed-off-by: Omkar Phansopkar <[email protected]>
Signed-off-by: Omkar Phansopkar <[email protected]>
Signed-off-by: Omkar Phansopkar <[email protected]>
Signed-off-by: Omkar Phansopkar <[email protected]>
Signed-off-by: Omkar Phansopkar <[email protected]>
Signed-off-by: Omkar Phansopkar <[email protected]>
Signed-off-by: Omkar Phansopkar <[email protected]>
Signed-off-by: Omkar Phansopkar <[email protected]>
Signed-off-by: Omkar Phansopkar <[email protected]>
Signed-off-by: Omkar Phansopkar <[email protected]>
Signed-off-by: Omkar Phansopkar <[email protected]>
Signed-off-by: Omkar Phansopkar <[email protected]>
Signed-off-by: Omkar Phansopkar <[email protected]>
…ild errors Signed-off-by: Omkar Phansopkar <[email protected]>
…etree render Signed-off-by: Omkar Phansopkar <[email protected]>
Signed-off-by: Omkar Phansopkar <[email protected]>
Fix irregular scroll behavior for files in deeply nested FileTree
Close file option & cleanup before imports
Signed-off-by: Omkar Phansopkar <[email protected]>
Signed-off-by: Omkar Phansopkar <[email protected]>
Signed-off-by: Omkar Phansopkar <[email protected]>
Signed-off-by: Omkar Phansopkar <[email protected]>
Signed-off-by: Omkar Phansopkar <[email protected]>
Signed-off-by: Omkar Phansopkar <[email protected]>
Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
Fixed Empty directory being shown with file icon
…ble dimensions Signed-off-by: Omkar Phansopkar <[email protected]>
Signed-off-by: Omkar Phansopkar <[email protected]>
Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
Automatic height for table
… outdated docs Signed-off-by: Omkar Phansopkar <[email protected]>
Signed-off-by: Omkar Phansopkar <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM @OmkarPh, thanks!
Some minor things to note:
- Are https://github.com/nexB/scancode-workbench/tree/feature/unittests/test-old and https://github.com/nexB/scancode-workbench/tree/feature/unittests/test-db used currently and if not should they not be removed entirely?
- The husky pre-commit increases the time to create commits, and usually we run only linters and other smaller/faster checks in pre-commits, and not the full test-suite? This time will increase when there are more comprehensive tests so this is something that should be considered.
But we can do these separately too, feel free to merge.
Update Documentation
Merging! #591 (review) can be addressed at #556 |
This, was fixed in other branch.
Ohk, lets discuss about this later |
Also fixes #601