Filter using extension field rather than path #238

Signed-off-by: Jono Yang <[email protected]>
aboutcode-org · Jul 26, 2021 · 25531ca · 25531ca
1 parent ad83ae7
commit 25531ca
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 4 deletions.
diff --git a/scanpipe/pipes/windows.py b/scanpipe/pipes/windows.py
@@ -74,7 +74,7 @@ def tag_uninteresting_windows_codebase_resources(project):
     for file_name in uninteresting_files:
         lookups |= Q(path__iendswith=file_name)
     for file_extension in uninteresting_file_extensions:
-        lookups |= Q(path__icontains=file_extension)
+        lookups |= Q(extension__icontains=file_extension)
 
     qs = project.codebaseresources.no_status()
     qs.filter(lookups).update(status="ignored-not-interesting")

diff --git a/scanpipe/tests/test_pipes.py b/scanpipe/tests/test_pipes.py
@@ -706,7 +706,8 @@ def test_scanpipe_pipes_windows_tag_uninteresting_windows_codebase_resources(sel
         resource1 = CodebaseResource.objects.create(
             project=p1,
             path="root/Files/example.lnk",
-            rootfs_path="/Files/example.lnk"
+            rootfs_path="/Files/example.lnk",
+            extension=".lnk"
         )
         resource2 = CodebaseResource.objects.create(
             project=p1,
@@ -716,12 +717,14 @@ def test_scanpipe_pipes_windows_tag_uninteresting_windows_codebase_resources(sel
         resource3 = CodebaseResource.objects.create(
             project=p1,
             path="root/Files/example.dat",
-            rootfs_path="/Files/example.dat"
+            rootfs_path="/Files/example.dat",
+            extension=".dat"
         )
         resource4 = CodebaseResource.objects.create(
             project=p1,
             path="root/Files/User/Test/foo.dat",
-            rootfs_path="/Files/User/Test/foo.dat"
+            rootfs_path="/Files/User/Test/foo.dat",
+            extension=".dat"
         )
 
         windows.tag_uninteresting_windows_codebase_resources(p1)