Angular SSR + Shopularity Sample Project #3
Conversation
| @@ -0,0 +1,35 @@ | |||
| import {environment} from "../../environments/environment"; | |||
|
|
|||
| export function absolutizeRelativeUrls(html: string): string { | |||
There was a problem hiding this comment.
I could not understand where would we use this util.
| import {inject, Injectable} from "@angular/core"; | ||
| import {Rest, RestService} from "@abp/ng.core"; | ||
| import {PagedProducts, ProductWithCategory} from "../models"; | ||
| import ResponseType = Rest.ResponseType; |
There was a problem hiding this comment.
We could remove this import as it does not seem being used
import ResponseType = Rest.ResponseType;
| import {Pipe, PipeTransform} from "@angular/core"; | ||
| import {environment} from "../../environments/environment"; | ||
|
|
||
| @Pipe({ |
There was a problem hiding this comment.
I could not see the usage for this pipe, so maybe we could delete this.
There was a problem hiding this comment.
Hello @erdemcaygor thank you for putting an effort on creating this sample. Other than the comments I left, it is mergable 🙌🏻
We could also check these components using RouterModule import as it seems redundant.
-
Shopularity/angular/public-site/src/app/containers/product-list/product-list-item/product-list-item.component.ts -
Shopularity/angular/public-site/src/app/containers/product-list/product-list.component.ts -
Shopularity/angular/public-site/src/app/containers/product-detail/product-detail.component.ts
2 participants
Resolves https://github.com/volosoft/vs-internal/issues/7321