Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try different approach to test minimal versions #323

Merged
merged 2 commits into from
Aug 18, 2024
Merged

Conversation

abrain
Copy link
Owner

@abrain abrain commented Aug 18, 2024

Instead of manipulating the existing composer file, leverage the setup-php action to install the required test tools. This should prevent the test from breaking whenever the dependencies are updated in the composer.json.

@abrain abrain self-assigned this Aug 18, 2024
Copy link

codecov bot commented Aug 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 25.71%. Comparing base (79dbea0) to head (1f913a3).
Report is 3 commits behind head on develop.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop     #323   +/-   ##
==========================================
  Coverage      25.71%   25.71%           
  Complexity      1607     1607           
==========================================
  Files             81       81           
  Lines           6214     6214           
==========================================
  Hits            1598     1598           
  Misses          4616     4616           
Flag Coverage Δ
integration 12.00% <ø> (ø)
unit 15.27% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@abrain abrain merged commit 3a0d10e into develop Aug 18, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant