Moving runtime OS check to compiletime for better performance and size #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moved runtime checks for OS to compile-time removed useless header file os.h
abranhe
reviewed
Feb 9, 2020
There was a problem hiding this comment.
Thank you so much for your contribution, but there is a purpose why is like that. This is a clib package, which means that we can add dependencies to it.
We still can remove the deps/ directory since through installation it will automatically download those files from this package abranhe/os.c.
Then why is the folder there?
Just to keep consistency and for people who don't use clib can have access to the library just by downloading the repository.
And you mention also performance, but the running time complexity will still be the same. Size may not, but the use of small package helps with the readability of the library.
| cmd = "xdg-open"; | ||
| } | ||
| #ifdef _WIN32 | ||
| #define cmd "open" |
There was a problem hiding this comment.
On Windows, the open command won't work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.