Separate out test dependencies from the core bzlmod extensions (#105)

closes #104

MODULE.bazel

@@ -31,12 +31,6 @@ use_repo(
     "helm_windows_amd64_toolchain",
 )
 use_repo(helm, "go_yaml_yaml")
-use_repo(
-    helm,
-    "helm_test_deps__with_chart_deps_postgresql",
-    "helm_test_deps__with_chart_deps_redis",
-    "rules_helm_test_container_base",
-)
 
 register_toolchains(
     "@helm_darwin_amd64_toolchain//:toolchain",
@@ -45,3 +39,11 @@ register_toolchains(
     "@helm_linux_arm64_toolchain//:toolchain",
     "@helm_windows_amd64_toolchain//:toolchain",
 )
+
+helm_test = use_extension("@rules_helm//tests:test_extensions.bzl", "helm_test")
+use_repo(
+    helm_test,
+    "helm_test_deps__with_chart_deps_postgresql",
+    "helm_test_deps__with_chart_deps_redis",
+    "rules_helm_test_container_base",
+)

helm/extensions.bzl

@@ -2,24 +2,32 @@
 
 load("@bazel_tools//tools/build_defs/repo:http.bzl", "http_archive")
 load("@bazel_tools//tools/build_defs/repo:utils.bzl", "maybe")
-load("//helm:repositories.bzl", "helm_host_alias_repository", "helm_toolchain_repository")
-load("//helm/private:versions.bzl", "CONSTRAINTS", "DEFAULT_HELM_URL_TEMPLATES", "DEFAULT_HELM_VERSION", "HELM_VERSIONS")
-load("//tests:test_deps.bzl", "helm_test_deps")
+load(
+    "//helm:repositories.bzl",
+    "helm_host_alias_repository",
+    "helm_toolchain_repository",
+)
+load(
+    "//helm/private:versions.bzl",
+    "CONSTRAINTS",
+    "DEFAULT_HELM_URL_TEMPLATES",
+    "DEFAULT_HELM_VERSION",
+    "HELM_VERSIONS",
+)
 
 _HELM_TAR_BUILD_CONTENT = """\
 package(default_visibility = ["//visibility:public"])
 exports_files(glob(["**"]))
 """
 
-def _impl(ctx):
+def _helm_impl(ctx):
     module = ctx.modules[0]
     options = module.tags.options
     version = options[0].version
     helm_url_templates = options[0].helm_url_templates
 
     _register_toolchains(version, helm_url_templates)
     _register_go_yaml()
-    helm_test_deps()
 
 def _register_toolchains(version, helm_url_templates):
     if not version in HELM_VERSIONS:
@@ -45,10 +53,15 @@ def _register_toolchains(version, helm_url_templates):
             http_archive,
             name = name,
             urls = [
-                template.format(
-                    version = version,
-                    platform = url_platform,
-                    compression = compression,
+                template.replace(
+                    "{version}",
+                    version,
+                ).replace(
+                    "{platform}",
+                    url_platform,
+                ).replace(
+                    "{compression}",
+                    compression,
                 )
                 for template in helm_url_templates
             ],
@@ -79,11 +92,21 @@ def _register_go_yaml():
     )
 
 options = tag_class(attrs = {
-    "helm_url_templates": attr.string_list(default = DEFAULT_HELM_URL_TEMPLATES),
-    "version": attr.string(default = DEFAULT_HELM_VERSION),
+    "helm_url_templates": attr.string_list(
+        doc = (
+            "A url template used to download helm. The template can contain the following " +
+            "format strings `{platform}` for the helm platform, `{version}` for the helm " +
+            "version, and `{compression}` for the archive type containing the helm binary."
+        ),
+        default = DEFAULT_HELM_URL_TEMPLATES,
+    ),
+    "version": attr.string(
+        doc = "The version of helm to download for the toolchain.",
+        default = DEFAULT_HELM_VERSION,
+    ),
 })
 
 helm = module_extension(
-    implementation = _impl,
+    implementation = _helm_impl,
     tag_classes = {"options": options},
 )

tests/test_extensions.bzl

@@ -0,0 +1,10 @@
+"""Bzlmod test extensions"""
+
+load("//tests:test_deps.bzl", "helm_test_deps")
+
+def _helm_test_impl(_ctx):
+    helm_test_deps()
+
+helm_test = module_extension(
+    implementation = _helm_test_impl,
+)