Add support for + in package versions (#82)

abrisco · May 19, 2024 · b92b72d · b92b72d
1 parent a6be38c
commit b92b72d
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/helm/private/packager/packager.go b/helm/private/packager/packager.go
@@ -534,7 +534,7 @@ func findGeneratedPackage(logging string) (string, error) {
 }
 
 func writeResultsMetadata(packageBase string, metadataOutput string) error {
-	re := regexp.MustCompile(`(.*)-([\d][\d\w\-\.]+)\.tgz`)
+	re := regexp.MustCompile(`(.*)-([\d][\d\w\-\.+]+)\.tgz`)
 	match := re.FindAllStringSubmatch(packageBase, 2)
 
 	if len(match) == 0 {

diff --git a/tests/version_stamp/Chart.yaml b/tests/version_stamp/Chart.yaml
@@ -15,7 +15,7 @@ type: application
 # This is the chart version. This version number should be incremented each time you make changes
 # to the chart and its templates, including the app version.
 # Versions are expected to follow Semantic Versioning (https://semver.org/)
-version: "0.1.0-{STABLE_STAMP_VALUE}-{VOLATILE_STAMP_VALUE}"
+version: "0.1.0+{STABLE_STAMP_VALUE}-{VOLATILE_STAMP_VALUE}"
 
 # This is the version number of the application being deployed. This version number should be
 # incremented each time you make changes to the application. Versions are not expected to

diff --git a/tests/version_stamp/version_stamp_unit_test.bzl b/tests/version_stamp/version_stamp_unit_test.bzl
@@ -59,7 +59,7 @@ def version_stamp_test_suite(name):
         content = """\
 {
     "name": "version_stamp",
-    "version": "0.1.0-STABLE-STAMP-VALUE-VOLATILE-STAMP-VALUE"
+    "version": "0.1.0+STABLE-STAMP-VALUE-VOLATILE-STAMP-VALUE"
 }
 """.splitlines(),
         newline = "unix",
@@ -77,7 +77,7 @@ def version_stamp_test_suite(name):
         content = """\
 {
     "name": "version_stamp",
-    "version": "0.1.0-stable-volatile"
+    "version": "0.1.0+stable-volatile"
 }
 """.splitlines(),
         newline = "unix",