Ability to specify additional files to be added to the chart

[dormidon]

Try to address #74

• files attribute added to helm_package
• it receives map from fileset to directory inside a chart where the whole fileset will be copied

Could be used as

filegroup(
    name = "configs",
    srcs = glob([
        "configs/**",
    ]),
)

helm_package(
    name = "package",
    files = {
        ":configs": "configs",
    },
    # rest of target parameters
)

In this case all file structure under configs directory will be copied to configs directory "inside" chart and would be available via .Files.Get ("configs/my-config.yaml")

[abrisco]

Thanks for the change and sorry for the delay on the review! Out of curiosity, why not add the files field that builds a runfiles-like directory? It seems like that would make loading files more consistent but would also mean your charts will probably be different in and out of bazel if you're trying to continue to support both.

[dormidon]

Hello!

Thank you for the feedback.

Out of curiosity, why not add the files field that builds a runfiles-like directory?

It seems that the answer is simple - because of lack of experience with Bazel :)
Could you please provide more details about your idea how it could be improved?

[abrisco]

Hello!

Thank you for the feedback.

Out of curiosity, why not add the files field that builds a runfiles-like directory?

It seems that the answer is simple - because of lack of experience with Bazel :) Could you please provide more details about your idea how it could be improved?

I've left a comment with hopefully a useful suggestion!

[abrisco]

Kinda hard to use suggestions to suggest exactly what I'm thinking but:

Suggested change

	for ln in ctx.attr.files:
	def _rlocationpath(file, workspace_name):
	if file.short_path.startswith("../"):
	return file.short_path[len("../"):]
	return "{}/{}".format(workspace_name, file.short_path)
	workspace_name = ctx.workspace_name
	def _rlocationpath_mapping(file):
	return "-add_files={}={}".format(file.path, _rlocationpath(file, workspace_name))
	args.add_all(ctx.files.files, map_each = _rlocationpath_mapping, allow_closure = True)

Anyone familiar with Runfiles APIs (e.g. rust, python) should have an easy time finding files and not need to refer to the BUILD file target to understand what files are included and where to find them.