Improve module extension #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mering
force-pushed
the
improve-module-extension
branch
2 times, most recently
from
e860daa to
e4bb9c3
Compare
This makes it more obvious to the user what this tag does.
mering
force-pushed
the
improve-module-extension
branch
4 times, most recently
from
a39ce9d to
2e5f44a
Compare
The generated repository name currently doesn't encode any other option so we can only register a single toolchain for now. Use more elaborate logic: - Only allow registering a toolchain in the root module - Only allow specifying a single toolchain and fail otherwise
mering
force-pushed
the
improve-module-extension
branch
from
2e5f44a to
b5bb64f
Compare
mering
added a commit
to mering/rules_helm
that referenced
this pull request
Jan 8, 2025
abrisco
pushed a commit
that referenced
this pull request
Jan 23, 2025
Improvements after #130. This makes sure that there is always exactly one toolchain defined, either in the root module or picking the default one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
helm.optionstohelm.toolchainand this tag generates a new toolchain