fix: incorrect host alias symlink on some platforms #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kormide
force-pushed
the
fix-host-alias-symlink
branch
from
a44b638 to
c7f1123
Compare
kormide
changed the title
kormide
commented
May 13, 2024
| @@ -124,12 +125,9 @@ exports_files(["helm{ext}"]) | |||
| ext = ext, | |||
| )) | |||
|
|
|||
| platform = "{}_{}".format(repository_ctx.os.name, repository_ctx.os.arch) | |||
| platform_repo_name = _helm_bin_repo_name(platform) | |||
There was a problem hiding this comment.
One of the bugs here (and I must have not been testing under bzlmod) is that we need to use the actual name from the repository context to properly capture the bzlmod repo path in the symlink.
kormide
commented
May 13, 2024
kormide
force-pushed
the
fix-host-alias-symlink
branch
4 times, most recently
from
96cc0c0 to
1e8b98c
Compare
abrisco
requested changes
May 13, 2024
abrisco
requested changes
May 13, 2024
kormide
force-pushed
the
fix-host-alias-symlink
branch
2 times, most recently
from
1703734 to
dfed62e
Compare
kormide
force-pushed
the
fix-host-alias-symlink
branch
from
dfed62e to
4ab8ce3
Compare
kormide
force-pushed
the
fix-host-alias-symlink
branch
from
4ab8ce3 to
e88448a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #78.