This repository has been archived by the owner on Jun 12, 2019. It is now read-only.
Support insertId and other optional params in Tabledata.insertAll #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kysnm
added a commit
to kysnm/BigQuery
that referenced
this pull request
Apr 20, 2016
In VCR, empty response body may be converted to an empty string, which raises error when we call resp.to_h. Check the response for nil and empty string, and converts it to an empty hash manually.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In my use case, I use
BigQuery::Client::Tables.insertwith large arrays frequently.Sometimes they succeed partially, i.e. half rows of a batch are added, the other half fail.
Instead of checking the results and only resending the failed rows (so the good rows are not sent twice), I want to add
insertIdto each row, then let Google do the de-duplication for us.This is the main purpose of this PR.
It's quite hard to add
insertIdsupport to the existinginsert()method without changing its interface, so I create a newinsert_all().