Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MG-2410 - Add wrapper for authN/authZ #2411

Merged
merged 29 commits into from
Sep 9, 2024
Merged

MG-2410 - Add wrapper for authN/authZ #2411

merged 29 commits into from
Sep 9, 2024

Conversation

felixgateru
Copy link
Contributor

What type of PR is this?

This is a feature as it adds a wrapper for authn/authz that can be used by services instead of communication directly with the auth service.

What does this do?

This pr adds the following files:

  • pkg/auth/auth.go
  • pkg/auth/doc.go
  • internal/auth/auth.go
  • internal/auth/doc.go

Which issue(s) does this PR fix/relate to?

Have you included tests for your changes?

No,

Did you document any new/modified feature?

Yes, incode documentation for new functions has been done.

Notes

@felixgateru felixgateru changed the base branch from main to auth-middleware September 3, 2024 15:33
@felixgateru felixgateru force-pushed the mg2410-auth_wrapper branch 2 times, most recently from 16e8bee to c382f2b Compare September 4, 2024 12:21
@felixgateru felixgateru marked this pull request as ready for review September 4, 2024 12:21
@felixgateru
feat: split auth client
f323775 
Signed-off-by: 1998-felix <[email protected]>
@felixgateru
feat: split auth cliet into authnz and policy clients
5df6e48 
Signed-off-by: 1998-felix <[email protected]>
@felixgateru
feat: add tests
16ee560 
Signed-off-by: 1998-felix <[email protected]>
@felixgateru
refactor: rename clients
a5a0999 
Signed-off-by: 1998-felix <[email protected]>
@felixgateru
fix: fix property based tests
e649f32 
Signed-off-by: 1998-felix <[email protected]>
@felixgateru
refactor: refactor variable names to be more descriptive
4ca63a6 
Signed-off-by: 1998-felix <[email protected]>
@felixgateru
refactor: refactor log messages
e206e3b 
Signed-off-by: 1998-felix <[email protected]>
@felixgateru
refactor: rename file pkg/auth to pkg/grpcclient
2c639cf 
Signed-off-by: 1998-felix <[email protected]>
@felixgateru
refactor: rename things grpc service to authz service
8a3f509 
Signed-off-by: 1998-felix <[email protected]>
@felixgateru
refactor: refactor client type in adapters
86e33b3 
Signed-off-by: 1998-felix <[email protected]>
@felixgateru
refactor: rebase
c60d52c 
Signed-off-by: 1998-felix <[email protected]>
@felixgateru
feat: move spicedb to policy service
80186d6 
Signed-off-by: 1998-felix <[email protected]>
@felixgateru
feat: add middleware to policy
da351e6 
Signed-off-by: 1998-felix <[email protected]>
@felixgateru
feat: split auth client
e79b945 
Signed-off-by: 1998-felix <[email protected]>
@felixgateru
feat: split auth cliet into authnz and policy clients
54c8c19 
Signed-off-by: 1998-felix <[email protected]>
@felixgateru
feat: add tests
fbf2d90 
Signed-off-by: 1998-felix <[email protected]>
@felixgateru
refactor: rename clients
f2bbb32 
Signed-off-by: 1998-felix <[email protected]>
@felixgateru
fix: fix property based tests
eb7e150 
Signed-off-by: 1998-felix <[email protected]>
@felixgateru
refactor: refactor variable names to be more descriptive
1ecde99 
Signed-off-by: 1998-felix <[email protected]>
@felixgateru
refactor: refactor log messages
a58a357 
Signed-off-by: 1998-felix <[email protected]>
@felixgateru
refactor: rename file pkg/auth to pkg/grpcclient
8edf2c3 
Signed-off-by: 1998-felix <[email protected]>
@felixgateru
refactor: rename things grpc service to authz service
5f7ed1e 
Signed-off-by: 1998-felix <[email protected]>
@felixgateru
refactor: refactor client type in adapters
ad51738 
Signed-off-by: 1998-felix <[email protected]>
@felixgateru
feat: add auth client wrapper
29b9b54 
Signed-off-by: 1998-felix <[email protected]>
@felixgateru
refactor: rebase
209f1d8 
Signed-off-by: 1998-felix <[email protected]>
@felixgateru
refactor: rebase
66bc098 
Signed-off-by: 1998-felix <[email protected]>
dborovcanin
dborovcanin requested changes Sep 6, 2024
View reviewed changes
internal/auth/wrapper.go Outdated Show resolved Hide resolved
pkg/auth/auth.go Outdated Show resolved Hide resolved
@dborovcanin dborovcanin merged commit b468d93 into absmach:auth-middleware Sep 9, 2024
2 checks passed
dborovcanin pushed a commit that referenced this pull request Sep 10, 2024
@felixgateru @dborovcanin
MG-2410 - Add wrapper for authN/authZ (#2411)
b5c11c3 
Signed-off-by: 1998-felix <[email protected]>
dborovcanin pushed a commit that referenced this pull request Sep 12, 2024
@felixgateru @dborovcanin
MG-2410 - Add wrapper for authN/authZ (#2411)
f4dd3b1 
Signed-off-by: 1998-felix <[email protected]>
dborovcanin pushed a commit that referenced this pull request Sep 13, 2024
@felixgateru @dborovcanin
MG-2410 - Add wrapper for authN/authZ (#2411)
0aa4556 
Signed-off-by: 1998-felix <[email protected]>
dborovcanin pushed a commit that referenced this pull request Sep 19, 2024
@felixgateru @dborovcanin
MG-2410 - Add wrapper for authN/authZ (#2411)
bdbaed9 
Signed-off-by: 1998-felix <[email protected]>
dborovcanin pushed a commit that referenced this pull request Sep 24, 2024
@felixgateru @dborovcanin
MG-2410 - Add wrapper for authN/authZ (#2411)
be97474 
Signed-off-by: 1998-felix <[email protected]>
nyagamunene pushed a commit to nyagamunene/magistrala that referenced this pull request Sep 25, 2024
@felixgateru @nyagamunene
MG-2410 - Add wrapper for authN/authZ (absmach#2411)
cf57eb2 
Signed-off-by: 1998-felix <[email protected]>
Signed-off-by: nyagamunene <[email protected]>
dborovcanin pushed a commit to nyagamunene/magistrala that referenced this pull request Sep 27, 2024
@felixgateru @dborovcanin
MG-2410 - Add wrapper for authN/authZ (absmach#2411)
1ef87c6 
Signed-off-by: 1998-felix <[email protected]>
Signed-off-by: nyagamunene <[email protected]>
felixgateru added a commit to felixgateru/magistrala that referenced this pull request Sep 30, 2024
@felixgateru
MG-2410 - Add wrapper for authN/authZ (absmach#2411)
a67af86 
Signed-off-by: 1998-felix <[email protected]>
nyagamunene pushed a commit to nyagamunene/magistrala that referenced this pull request Oct 1, 2024
@felixgateru @nyagamunene
MG-2410 - Add wrapper for authN/authZ (absmach#2411)
144eac0 
Signed-off-by: 1998-felix <[email protected]>
Signed-off-by: nyagamunene <[email protected]>
dborovcanin pushed a commit that referenced this pull request Oct 3, 2024
@felixgateru @dborovcanin
MG-2410 - Add wrapper for authN/authZ (#2411)
4c44abe 
Signed-off-by: 1998-felix <[email protected]>
dborovcanin pushed a commit that referenced this pull request Oct 7, 2024
@felixgateru @dborovcanin
MG-2410 - Add wrapper for authN/authZ (#2411)
7ec6151 
Signed-off-by: 1998-felix <[email protected]>
nyagamunene pushed a commit to nyagamunene/magistrala that referenced this pull request Oct 7, 2024
@felixgateru @nyagamunene
MG-2410 - Add wrapper for authN/authZ (absmach#2411)
b6bb30f 
Signed-off-by: 1998-felix <[email protected]>
Signed-off-by: nyagamunene <[email protected]>
dborovcanin pushed a commit to nyagamunene/magistrala that referenced this pull request Oct 8, 2024
@felixgateru @dborovcanin
MG-2410 - Add wrapper for authN/authZ (absmach#2411)
8d2b87b 
Signed-off-by: 1998-felix <[email protected]>
Signed-off-by: nyagamunene <[email protected]>
nyagamunene pushed a commit to nyagamunene/magistrala that referenced this pull request Oct 8, 2024
@felixgateru @nyagamunene
MG-2410 - Add wrapper for authN/authZ (absmach#2411)
b2bf23c 
Signed-off-by: 1998-felix <[email protected]>
Signed-off-by: nyagamunene <[email protected]>
dborovcanin pushed a commit that referenced this pull request Oct 14, 2024
@felixgateru @dborovcanin
MG-2410 - Add wrapper for authN/authZ (#2411)
19f56f1 
Signed-off-by: 1998-felix <[email protected]>
felixgateru added a commit to felixgateru/magistrala that referenced this pull request Oct 15, 2024
@felixgateru
MG-2410 - Add wrapper for authN/authZ (absmach#2411)
a9422d2 
Signed-off-by: 1998-felix <[email protected]>
felixgateru added a commit that referenced this pull request Oct 15, 2024
@felixgateru
MG-2410 - Add wrapper for authN/authZ (#2411)
4f47802 
Signed-off-by: 1998-felix <[email protected]>
dborovcanin pushed a commit that referenced this pull request Oct 15, 2024
@felixgateru @dborovcanin
MG-2410 - Add wrapper for authN/authZ (#2411)
56cbf90 
Signed-off-by: 1998-felix <[email protected]>
dborovcanin pushed a commit to dborovcanin/magistrala that referenced this pull request Oct 15, 2024
@felixgateru @dborovcanin
MG-2410 - Add wrapper for authN/authZ (absmach#2411)
23a1e11 
Signed-off-by: 1998-felix <[email protected]>
Signed-off-by: Dusan Borovcanin <[email protected]>
dborovcanin pushed a commit that referenced this pull request Oct 17, 2024
@felixgateru @dborovcanin
MG-2410 - Add wrapper for authN/authZ (#2411)
f90b3a0 
Signed-off-by: 1998-felix <[email protected]>
Signed-off-by: Dusan Borovcanin <[email protected]>
felixgateru added a commit to felixgateru/magistrala that referenced this pull request Oct 24, 2024
@felixgateru
MG-2410 - Add wrapper for authN/authZ (absmach#2411)
7014ef2 
Signed-off-by: 1998-felix <[email protected]>
Signed-off-by: Dusan Borovcanin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dborovcanin dborovcanin dborovcanin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Magistrala
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature: Create wrapper for Authn/Authz
2 participants
@felixgateru @dborovcanin