NOISSUE - Add Domains Service #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Musilah
force-pushed
the
domainsnew
branch
2 times, most recently
from
84092ff
to
6a0d90b
Compare
ianmuchyri
requested changes
Mar 28, 2024
src/domains.ts
Outdated
| this.domainError = new Errors() | ||
| } | ||
|
|
||
| public async CreateDomain (domain: Domain, token: string): Promise<Domain | undefined> { |
There was a problem hiding this comment.
we should not provision for a return of undefined assert the type to be Domain only. We should only either return domain or an error, nothing else.
Apply this to the others as well
ianmuchyri
requested changes
Mar 29, 2024
src/domains.ts
Outdated
| } | ||
| } | ||
|
|
||
| public async RemoveUserfromDomain (domainID: string, userIDs: string[], relation: string, token: string): Promise<any> { |
There was a problem hiding this comment.
For this you can return the statuscode
src/domains.ts
Outdated
| } | ||
| } | ||
|
|
||
| public async AddUsertoDomain (domainID: string, userIDs: string[], relation: string, token: string): Promise<string> { |
There was a problem hiding this comment.
same for this. return statusCode, or you can create a return interface, that will return the status code and the message.
src/domains.ts
Outdated
| limit: number | ||
| } | ||
|
|
||
| interface DomainsInterface { |
There was a problem hiding this comment.
Suggested change
| interface DomainsInterface { | |
| interface DomainsPage { |
Musilah
force-pushed
the
domainsnew
branch
2 times, most recently
from
dc61969
to
7a4787a
Compare
Signed-off-by: Musilah <[email protected]>
Signed-off-by: Musilah <[email protected]>
Signed-off-by: Musilah <[email protected]>
Signed-off-by: Musilah <[email protected]>
Signed-off-by: Musilah <[email protected]>
Signed-off-by: Musilah <[email protected]>
ianmuchyri
requested changes
Apr 4, 2024
src/defs.ts
Outdated
| name?: string | ||
| id?: string | ||
| alias?: string | ||
| email?: string |
There was a problem hiding this comment.
domain does not have param email. The create domain struct looks like so:
type Domain struct {
ID string `json:"id,omitempty"`
Name string `json:"name,omitempty"`
Metadata Metadata `json:"metadata,omitempty"`
Tags []string `json:"tags,omitempty"`
Alias string `json:"alias,omitempty"`
Status string `json:"status,omitempty"`
Permission string `json:"permission,omitempty"`
CreatedBy string `json:"created_by,omitempty"`
CreatedAt time.Time `json:"created_at,omitempty"`
UpdatedBy string `json:"updated_by,omitempty"`
UpdatedAt time.Time `json:"updated_at,omitempty"`
Permissions []string `json:"permissions,omitempty"`
}
src/domains.ts
Outdated
| } | ||
| } | ||
|
|
||
| public async EnableDomain (domainID: string, token: string): Promise<Domain> { |
There was a problem hiding this comment.
Enable and disable domain do not return the domain. Just an status code and/or error incase of an error
Signed-off-by: Musilah <[email protected]>
Signed-off-by: Musilah <[email protected]>
dborovcanin
requested changes
Apr 4, 2024
dborovcanin
approved these changes
Apr 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do?
This adds the Domains Service to the sdk.
Which issue(s) does this PR fix/relate to?
Resolves #13
List any changes that modify/break current functionality
Have you included tests for your changes?
Did you document any new/modified functionality?
Notes