MG-2136 - Generate mocks with mockery for Bootstrap service #2128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please sign off your commits, check DCO report here and fix. |
WashingtonKK
requested changes
Mar 28, 2024
|
Also update the mockery version used to use the latest version |
Signed-off-by: nyagamunene <[email protected]>
Signed-off-by: nyagamunene <[email protected]>
Signed-off-by: nyagamunene <[email protected]>
Signed-off-by: nyagamunene <[email protected]>
Signed-off-by: nyagamunene <[email protected]>
nyagamunene
force-pushed
the
MG-1993-GenerateMocksPerService
branch
from
321c76e to
2b56793
Compare
Signed-off-by: nyagamunene <[email protected]>
Signed-off-by: nyagamunene <[email protected]>
Signed-off-by: nyagamunene <[email protected]>
Signed-off-by: nyagamunene <[email protected]>
nyagamunene
changed the title
arvindh123
changed the title
rodneyosodo
requested changes
Apr 4, 2024
| @@ -60,6 +60,8 @@ type ConfigsPage struct { | |||
| } | |||
|
|
|||
| // ConfigRepository specifies a Config persistence API. | |||
| // | |||
| //go:generate mockery --name ConfigRepository --output=./mocks --filename configs.go --quiet --note "Copyright (c) Abstract Machines" | |||
There was a problem hiding this comment.
Run
make mocksto generate the mocks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
This is a feature because its add the following functionality: generates mocks for bootstrap.
What does this do?
It generates the mocks for bootstrap service.
Which issue(s) does this PR fix/relate to?
Have you included tests for your changes?
Yes, I have included tests.
Did you document any new/modified feature?
No, I have not updated the documentation.
Notes