MG-2125 - Unable to enable thing using bootstrap #2132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeffMboya
changed the title
arvindh123
reviewed
Apr 3, 2024
felixgateru
requested changes
Apr 3, 2024
JeffMboya
force-pushed
the
thing-connect-event-consumption
branch
4 times, most recently
from
aaa3f71 to
2e78700
Compare
Signed-off-by: JeffMboya <[email protected]>
Signed-off-by: JeffMboya <[email protected]>
JeffMboya
force-pushed
the
thing-connect-event-consumption
branch
from
2e78700 to
61e874c
Compare
arvindh123
previously approved these changes
Apr 3, 2024
felixgateru
previously approved these changes
Apr 3, 2024
dborovcanin
requested changes
Apr 3, 2024
Comment on lines
+328
to
+330
| if errors.Contains(err, svcerr.ErrConflict) { | ||
| continue | ||
| } |
There was a problem hiding this comment.
Please add a comment explaining why we are ignoring the conflicts.
Signed-off-by: JeffMboya <[email protected]>
dborovcanin
previously approved these changes
Apr 3, 2024
Signed-off-by: JeffMboya <[email protected]>
nyagamunene
pushed a commit
to nyagamunene/supermq
that referenced
this pull request
Apr 4, 2024
Signed-off-by: JeffMboya <[email protected]>
nyagamunene
pushed a commit
to nyagamunene/supermq
that referenced
this pull request
Apr 5, 2024
Signed-off-by: JeffMboya <[email protected]> Signed-off-by: nyagamunene <[email protected]>
nyagamunene
pushed a commit
to nyagamunene/supermq
that referenced
this pull request
Apr 7, 2024
Signed-off-by: JeffMboya <[email protected]> Signed-off-by: nyagamunene <[email protected]>
JeffMboya
added a commit
to JeffMboya/supermq
that referenced
this pull request
Apr 11, 2024
Signed-off-by: JeffMboya <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
This is a bug fix.
What does this do?
This PR introduces
svcerr.ErrConflictinto theConnectfunction. Thesvcerr.ErrConflicterror is triggered when an attempt is made to establish a connection that already exists. In this case, instead of halting the process, theConnectfunction skips the current iteration and returnsHTTP/1.1 200 OK(because the desired end state - a connection existing- is already true for the current channel) and moves on to the next channel. This ensures that all channels inconIDsare processed, and any existing connections do not interrupt the operation.Which issue(s) does this PR fix/relate to?
Have you included tests for your changes?
No
Did you document any new/modified feature?
No, I have not updated the documentation because the changes are related to error handling and do not introduce new functionality.