Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MG-2143 - Generate mocks with mockery for Invitations service #2144

Merged

Conversation

nyagamunene
Copy link
Contributor

What type of PR is this?

This is a feature because its add the following functionality: generates mocks for invitations.

What does this do?

It generates the mocks for invitations service.

Which issue(s) does this PR fix/relate to?

Have you included tests for your changes?

Yes, I have included tests

Did you document any new/modified feature?

No, I have not updated the documentation.

Notes

@nyagamunene nyagamunene self-assigned this Apr 8, 2024
@nyagamunene nyagamunene changed the title MG-2136 - Generate mocks with mockery for Invitations service MG-2143 - Generate mocks with mockery for Invitations service Apr 8, 2024
@nyagamunene nyagamunene marked this pull request as ready for review April 8, 2024 15:47
@nyagamunene nyagamunene force-pushed the MG-GenerateMocksForInvitations branch 2 times, most recently from 3a63755 to 014528c Compare April 9, 2024 10:29
@@ -93,6 +95,7 @@ type Service interface {
DeleteInvitation(ctx context.Context, token, userID, domainID string) (err error)
}

//go:generate mockery --name Repository --output=./mocks --filename invitations.go --quiet --note "Copyright (c) Abstract Machines"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
//go:generate mockery --name Repository --output=./mocks --filename invitations.go --quiet --note "Copyright (c) Abstract Machines"
//go:generate mockery --name Repository --output=./mocks --filename repository.go --quiet --note "Copyright (c) Abstract Machines"

Copy link
Contributor

@felixgateru felixgateru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dborovcanin dborovcanin force-pushed the MG-GenerateMocksForInvitations branch from d9beaab to 512b599 Compare April 9, 2024 17:12
@dborovcanin dborovcanin merged commit 634e68d into absmach:main Apr 9, 2024
4 checks passed
JeffMboya pushed a commit to JeffMboya/supermq that referenced this pull request Apr 10, 2024
@nyagamunene nyagamunene added this to the S2 milestone Apr 11, 2024
JeffMboya pushed a commit to JeffMboya/supermq that referenced this pull request Apr 11, 2024
@JeffMboya JeffMboya mentioned this pull request Apr 14, 2024
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

Feature: Generate mocks with mockery for Invitations service
4 participants