-
Notifications
You must be signed in to change notification settings - Fork 672
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MG-2143 - Generate mocks with mockery for Invitations service #2144
Merged
dborovcanin
merged 3 commits into
absmach:main
from
nyagamunene:MG-GenerateMocksForInvitations
Apr 9, 2024
Merged
MG-2143 - Generate mocks with mockery for Invitations service #2144
dborovcanin
merged 3 commits into
absmach:main
from
nyagamunene:MG-GenerateMocksForInvitations
Apr 9, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3a63755
to
014528c
Compare
rodneyosodo
requested changes
Apr 9, 2024
invitations/invitations.go
Outdated
@@ -93,6 +95,7 @@ type Service interface { | |||
DeleteInvitation(ctx context.Context, token, userID, domainID string) (err error) | |||
} | |||
|
|||
//go:generate mockery --name Repository --output=./mocks --filename invitations.go --quiet --note "Copyright (c) Abstract Machines" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
//go:generate mockery --name Repository --output=./mocks --filename invitations.go --quiet --note "Copyright (c) Abstract Machines" | |
//go:generate mockery --name Repository --output=./mocks --filename repository.go --quiet --note "Copyright (c) Abstract Machines" |
rodneyosodo
approved these changes
Apr 9, 2024
felixgateru
approved these changes
Apr 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: nyagamunene <[email protected]>
Signed-off-by: nyagamunene <[email protected]>
Signed-off-by: nyagamunene <[email protected]>
d9beaab
to
512b599
Compare
dborovcanin
approved these changes
Apr 9, 2024
JeffMboya
pushed a commit
to JeffMboya/supermq
that referenced
this pull request
Apr 10, 2024
…h#2144) Signed-off-by: nyagamunene <[email protected]>
JeffMboya
pushed a commit
to JeffMboya/supermq
that referenced
this pull request
Apr 11, 2024
…h#2144) Signed-off-by: nyagamunene <[email protected]> Signed-off-by: JeffMboya <[email protected]>
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
This is a feature because its add the following functionality: generates mocks for invitations.
What does this do?
It generates the mocks for invitations service.
Which issue(s) does this PR fix/relate to?
Have you included tests for your changes?
Yes, I have included tests
Did you document any new/modified feature?
No, I have not updated the documentation.
Notes