Adding Custom Fields Support #5
Conversation
hermeswaldemarin
force-pushed
the
feature/add-custom-fields-support
branch
3 times, most recently
from
a5a821d
to
00d7f83
Compare
src/Experiment.php
Outdated
| @@ -25,6 +25,7 @@ class Experiment { | |||
| public bool $audienceStrict; | |||
| public array $applications; | |||
| public array $variants; | |||
| public ?array $customFieldValues; | |||
There was a problem hiding this comment.
not aligned with previous lines
There was a problem hiding this comment.
the code style was different. Changed.
hermeswaldemarin
force-pushed
the
feature/add-custom-fields-support
branch
3 times, most recently
from
7be632b
to
4c04d35
Compare
|
|
||
| class ContextCustomFieldValue { | ||
| public string $type; | ||
| public $value; |
There was a problem hiding this comment.
I guess the type is not mandatory right? but if you put it, you get some help from the compiler?
Another thing: the value seems to be badly formatted?
There was a problem hiding this comment.
I'm not very familiar with PHP but is not required the type. I tried with object but don't work when I need to assign integer, booleans etc. The way I could make it work for all types is without the type declaration.
If you have another idea how to do that let me know.
The ideia is the value to be of Any type.
There was a problem hiding this comment.
The format was resolved already.
hermeswaldemarin
force-pushed
the
feature/add-custom-fields-support
branch
from
4c04d35
to
ed23fe1
Compare
No description provided.