bugfix: Add support for negative heights #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, I saw that you had forked this library and improved it so I thought this might be a better place than Sourceforge for other bug fixes. I've been trying to find a library that copes with negative heights but failed so here is an attempt at fixing it. I'm not sure if it's worth also handling negative widths too? I don't know how common a right hand origin would be. |
Missing braces caused color table to be overwritten every time a BMP was written to file.
An exception was raised if, for < 16-bit depths, the color table was not fully specified. This isn't illegal and the following code seems to pad the unspecified entries with white anyway.
BMP files with a negative height imply that the origin is top left so we need to swap all rows.
shareefj
force-pushed
the
bugfix/support_negative_heights
branch
from
d324952
to
bf2f34f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BMP files with a negative height imply that the origin is top left so we need to swap all rows.