Temporary fix for version dependency issues #137
Conversation
Release Candidate v2.0.1
…ability problems.
apexpy/tests/test_Apex.py
Outdated
| #@pytest.fixture() | ||
| #def igrf_file(max_attempts=100): | ||
| # """A fixture for handling the coefficient file. | ||
| # | ||
| # Parameters | ||
| # ---------- | ||
| # max_attempts : int | ||
| # Maximum rename attemps, needed for Windows (default=100) | ||
| # | ||
| # """ | ||
| # # Ensure the coefficient file exists | ||
| # original_file = os.path.join(os.path.dirname(apexpy.helpers.__file__), | ||
| # 'igrf13coeffs.txt') | ||
| # tmp_file = "temp_coeff.txt" | ||
| # assert os.path.isfile(original_file) | ||
| # | ||
| # # Move the coefficient file | ||
| # for _ in range(max_attempts): | ||
| # try: | ||
| # shutil.move(original_file, tmp_file) | ||
| # break | ||
| # except Exception: | ||
| # pass | ||
| # yield original_file | ||
| # | ||
| # # Move the coefficient file back | ||
| # for _ in range(max_attempts): | ||
| # try: | ||
| # shutil.move(tmp_file, original_file) | ||
| # break | ||
| # except Exception: | ||
| # pass | ||
| # return | ||
|
|
||
|
|
||
| #def test_set_epoch_file_error(igrf_file): | ||
| # """Test raises OSError when IGRF coefficient file is missing.""" | ||
| # # Test missing coefficient file failure | ||
| # with pytest.raises(OSError) as oerr: | ||
| # apexpy.Apex() | ||
| # error_string = "File {:} does not exist".format(igrf_file) | ||
| # assert str(oerr.value).startswith(error_string) | ||
| # return |
There was a problem hiding this comment.
| #@pytest.fixture() | |
| #def igrf_file(max_attempts=100): | |
| # """A fixture for handling the coefficient file. | |
| # | |
| # Parameters | |
| # ---------- | |
| # max_attempts : int | |
| # Maximum rename attemps, needed for Windows (default=100) | |
| # | |
| # """ | |
| # # Ensure the coefficient file exists | |
| # original_file = os.path.join(os.path.dirname(apexpy.helpers.__file__), | |
| # 'igrf13coeffs.txt') | |
| # tmp_file = "temp_coeff.txt" | |
| # assert os.path.isfile(original_file) | |
| # | |
| # # Move the coefficient file | |
| # for _ in range(max_attempts): | |
| # try: | |
| # shutil.move(original_file, tmp_file) | |
| # break | |
| # except Exception: | |
| # pass | |
| # yield original_file | |
| # | |
| # # Move the coefficient file back | |
| # for _ in range(max_attempts): | |
| # try: | |
| # shutil.move(tmp_file, original_file) | |
| # break | |
| # except Exception: | |
| # pass | |
| # return | |
| #def test_set_epoch_file_error(igrf_file): | |
| # """Test raises OSError when IGRF coefficient file is missing.""" | |
| # # Test missing coefficient file failure | |
| # with pytest.raises(OSError) as oerr: | |
| # apexpy.Apex() | |
| # error_string = "File {:} does not exist".format(igrf_file) | |
| # assert str(oerr.value).startswith(error_string) | |
| # return |
|
Re updating unit tests, agreed. That would be adding 3.11 and 3.12 to this line, correct? We'd expect 3.12 to fail at this point. |
Updated the python versions tested on GitHub Actions.
Added a yaml file for ReadTheDocs.
Updated the supported python versions in the documentation.
Moved the minimum supported python version to 3.9.
|
I just added up to 3.11, since we aren't supporting 3.12. We can add that in when we expect it to succeed. |
|
Sounds good. Just so you know, when you install in python 3.12, it still gives the error listed in #135 not a convenient "not supported" message unfortunately. It looks like pip tries to build the package before checking if it's a supported version, and I couldn't figure out if there was a way to make it act any differently. |
Try and avoid installing apexpy on RTD.
Updated the change log.
A new fix for just installing the desired packages.
Cycled supported python versions in the setup.cfg file.
Added flake8 to the test requirements.
Cycled the versions of github actions used, implementing the coveralls action.
Fixed a typo in the action name.
Removed extra whitespace.
Removed gcc version specification from the mac installation call.
Fixed the pip installation call in the tests.
Fixed test bugs: - changed pytest flags and - fixed pip install call for numpy.
MacOS is not supporting python 3.9 and 3.10. Changed OS for these versions to one that supports them. Also specifically call out gcc-14.
Put the OS names in quotation marks.
Comment line seemed to cause an error.
There's something wrong with the job matrix, attempt a fix.
Added space after dash. Also tried containsValue function for new macOS runs.
|
I think I fixed the unit tests so they pass, but now it looks like there's an error with reporting the tests? Will try to look more tomorrow... |
Determine where the xml file is located.
Removed tab from yaml.
Trying a new debug line.
Remove debug and move lines, hope for the best.
Try to use directory one level up in coveralls app.
Remove tab from yaml.
Added a debug line and also attempted to specify the output filename through pytest-cov.
Still leaving the tabs in.
Changed the filename to exclude directory.
Added more debug lines.
Removed tabs.
Change the debug command to include hidden files.
Try removing rootdir from pytest command.
Remove tab.
Trying to simplify the call again.
|
Ok, the current problem is that pytest-cov isn't creating an output file. I don't know why, the commands work locally on another package for me, but also fail locally (running in test directory). I am not sure how to debug this. |
Try coverage as a way to create the necessary output.
Fully revert to coverage, these commands work locally and the pytest ones don't.
Remove tab from yaml.
|
Ok, I had one more idea. The new command work locally, but not here 😢 |
|
Alternative is to remove coveralls for now. |
|
I don't want to rehash things you've already tried, but are we using the Coveralls GitHub Action? The most common reason I've found for GH Actions to mysteriously stop working is version updates in these that you need to include in the workflow file. |
|
@ljlamarche yes, it's basically required to use now, so we're using it. The main problem is that that tests aren't generating a coverage file (in any format) after they run. |
|
Ok, I have no other brilliant ideas... Go ahead and disable for now if you're comfortable with that. |
Try to remove the RC file from the coverage call.
This worked, remove the call for Windows as well.
|
@ljlamarche we did it! |
Description
This PR pins the version of numpy and python used in
pyproject.tomland clarifies in the documentation thatapexpyis currently not compatible with numpy 2.0 and python 3.12. A new minor release should be published to help users avoid some confusion with installation issues.This is a temporary fix for #134 and #135. These issues should not be closed as more comprehensive fixes should be implemented in the future.
Type of change
How Has This Been Tested?
Installation has been tested in a clean Python 3.11 environment to ensure expected behavior (successful installation of apexpy with numpy 1.26). Installation in a python 3.12 behavior fails, but it is now documented that apexpy does not support python 3.12.
From apexpy root directory:
Test Configuration
Checklist
develop(notmain) branchChangelog.rst, summarising the changesAUTHORS.rstand.zenodo.json