MAINT: Bugs and updates #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated .gitignore file for Mac systems.
Updated deprecation warnings with a version, addressing issue #109.
Updated pyproject.toml and deprecated the setup.py file.
Added test dependencies to pyproject.toml and added version capts to pysat.
Added a CI test for the ocbpy Release Candidate.
Updated the CI tests by: - updating the GitHub Actions versions, - use the pyproject.toml for installation, - add a new python test version, and - change the configuration file to pyproject.toml.
Update the package init file to obtain the version number from the pyproject.toml file.
Update the boundary directory discovery to use pathlib, since resources do not support directories.
Add a data catch for reading SuperMAG files without data and fix the docstring to reflect the correct outputs.
Added a docstring to the test init file.
Created a common class for logging tests and defined the test data directory as a variable.
Simplified vorticity tests by using common classes and variables.
Simplified SuperMAG tests by using common classes and variables.
Addressed a deprecation warning in the evaluation.
Reduced duplicate code and added checks by: - ensuring `max_sdiff` is always an integer, - specifying keys instead of accessing them impicitly, - using descriptive variables in evaluations, - reducing the number of loops by removing duplicate times from time index cycle, - added a function to pad and flatten data, and - combined similar processing loops.
Updated pysat unit tests by: - using common testing classes and variables, - updating instruments and load flags for upcoming pysat release, and - combined similar unit tests using subTest.
Updated the time unit test docstring formats.
Updated the scaling unit tests to use the common testing classes and variables.
Fixed bug in shape tests that prevented indexes and single values being evaluated correctly.
Fixed bug in common class calls and added the test_dir variable to more places.
Updated the general tests to use the common test class and variable.
pathlib behaves differently, added more checks to ensure correct behaviour.
Updated the files tests to use common classes and variables.
Use the appropriate unittest method for evaluating strings.
Updated the DMSP SSJ unit tests to use the common test class and variable.
Fixed file clean up for a test and re-combined logging tests after debugging.
Removed an unused import.
Ensure archive filename can be found whether or not it was freshly downloaded to the desired location.
Update the cycle unit tests to use the common test class and variable.
Updated the boundary tests to use the common classes and variables. Also updated behaviour to remove numpy deprecation warnings.
This reverts commit bca7423.
Try using the universal coveralls reporter.
|
The GitHub Actions coveralls app was not useful because:
|
The requests package is called explicitly in the DMSP SSJ unit tests.
Fix the yaml if statements to evaluate correctly.
Fix a different yaml bug.
MacOS is failing because it needs a token, create a yaml to store the token.
Fixed security leak for Coveralls.
Fixed token bug and windows execution bug.
Fix the windows coveralls command attempt 2.
Removed tab from yaml.
Windows is supposed to have tar from 2017 on, so this may work.
Use the windows snippet from the coverage reporter README instead of the example that isn't working.
Update main.yml for parallel coverage builds.
Removed an unnecessary download of coveralls reporter.
Improve the coveralls call by: - moving the installation up top, - using the parallel flag, and - explicitly declare the repo token.
Different OS versions have different executable names, and so require different commands.
Removed the old code block that didn't work.
Fixed the final coveralls call to use the linux standard.
Finish requires coveralls to be downloaded again.
|
coveralls coverage report still differs from local coverage report by 11% due to:
|
Update .gitignore to include the xml coverage output.
Coveralls-reported does a better job with xml output.
Added coveralls update to the changelog.
Removed tabs from the yaml.
Specify the coverage XML file instead of a general format.
Try adding build number through the GA `run_number` variable to the done call.
Try declaring the build-number across the board, to ensure it matches.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Addresses several issues - #128, #126, and #109 - and also:
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Ran unit tests locally.
Test Configuration
Checklist:
develop(notmain) branchChangelog.rst, summarising the changesAUTHORS.rstand.zenodo.json