-
-
Notifications
You must be signed in to change notification settings - Fork 408
refactor: replace GenerateApiParams
with GenerateApiConfiguration
config
#1232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
… config Signed-off-by: Sora Morimoto <[email protected]>
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR refactors the API generation configuration to replace the old GenerateApiParams
type with the new GenerateApiConfiguration
and updates the loadConfig
call accordingly.
- Swap
GenerateApiParams
import withGenerateApiConfiguration
- Change
loadConfig<GenerateApiParams>
toloadConfig<Partial<GenerateApiConfiguration["config"]>>
Comments suppressed due to low confidence (1)
index.ts:12
- [nitpick] Using the
GenerateApiConfiguration
type alongside bracket notation for itsconfig
property may be confusing. If the intention is to load only theconfig
portion, consider exporting and importing a dedicatedGenerateApiConfig
type to improve clarity.
GenerateApiConfiguration,
Signed-off-by: Sora Morimoto <[email protected]>
/** | ||
* extra templates | ||
*/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/** | |
* extra templates | |
*/ | |
/** | |
* extra templates | |
*/ | |
/** | |
* generate separated files for http client, data contracts, and routes (default: false) | |
*/ | |
modular?: boolean; |
No description provided.