Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect silent option by only logging errors #954

Merged
merged 1 commit into from
Oct 18, 2024
Merged

Conversation

Kiina
Copy link
Contributor

@Kiina Kiina commented Oct 15, 2024

Issue introduced by #903

Fixes #942

@Kiina Kiina force-pushed the patch-1 branch 2 times, most recently from b0386d5 to 8ac4d41 Compare October 15, 2024 11:13
@smorimoto
Copy link
Collaborator

It should be handled in the entry point: https://github.com/acacode/swagger-typescript-api/blob/main/src/index.ts

@Kiina
Copy link
Contributor Author

Kiina commented Oct 15, 2024

Adding it in the entrypoint didn't silence it when running:

tsx index.ts generate-templates --silent -p ./tests/fixtures/schemas/v3.0/petstore.yaml -o ./src -n myApi.ts

to test it, only when running:

tsx src/index.ts generate --silent -p ./tests/fixtures/schemas/v3.0/petstore.yaml -o ./src -n myApi.ts

So I added it there. But I can move it

@smorimoto smorimoto merged commit e1963a0 into acacode:main Oct 18, 2024
1 check passed
@smorimoto smorimoto added the bug Something isn't working label Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The option --silent is not honoured in version 13.0.22
2 participants