Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1322 fix type of studentnumber from number to string #1323

Open
wants to merge 4 commits into
base: dev
Choose a base branch
from

Conversation

pbc1017
Copy link
Contributor

@pbc1017 pbc1017 commented Jan 10, 2025

요약 *

만악의 근원은 db schema에 있었습니다.. blame myself

It closes #issue_number

스크린샷

이후 Task *

  • 없음

@pbc1017 pbc1017 self-assigned this Jan 10, 2025
@pbc1017 pbc1017 linked an issue Jan 10, 2025 that may be closed by this pull request
2 tasks
@Gerbera3090
Copy link
Contributor

이거 진짜 좋은데 그 funding 기간 끝나고 하지 않을래??
무서움....

@jooyeongmee
Copy link
Contributor

저도 머지는 지원금 후에 하는게 안전할거 같아요
쭉 훑어봤는데 누락된 부분 없는 것 같고 빌드도 안 터져서 문제 없어 보이네요
굳이굳이 얘기하자면 간혹 불필요한 toString()이 조금 남아 있는거 같은데 큰 문제는 없어서 무시해도 될거 같아

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix type of studentNumber from number to string
3 participants