Merge pull request #1647 from ojs/hotfix/author-removal

Make sure deleted authors are actually deleted

src/Ojs/JournalBundle/Controller/ArticleSubmissionController.php

@@ -396,8 +396,13 @@ public function editAction(Request $request, $id)
         );
         $this->throw404IfNotFound($article);
 
+        $originalAuthors = new ArrayCollection();
         $originalFiles = new ArrayCollection();
 
+        foreach ($article->getArticleAuthors() as $author) {
+            $originalAuthors->add($author);
+        }
+
         foreach ($article->getArticleFiles() as $file) {
             $originalFiles->add($file);
         }
@@ -418,6 +423,12 @@ public function editAction(Request $request, $id)
                 $i++;
             }
 
+            foreach ($originalAuthors as $author) {
+                if ($article->getArticleAuthors()->contains($author) === false) {
+                    $em->remove($author);
+                }
+            }
+
             foreach ($originalFiles as $file) {
                 if ($article->getArticleFiles()->contains($file) === false) {
                     $em->remove($file);